Inline keyword arguments passed to have_logged_event

[aduth]

🛠 Summary of changes

Updates analytics assertions in specs to inline properties passed to have_logged_event, rather than creating a separate variable to pass.

This is a somewhat subjective stylistic preference, though some more objective rationale is included below. It's meant to complement ongoing effort to standardize and refine logging assertions in specs.

Why?

• Improves readability of tests
  • Eyes are not moving around to find references to hash variable
    • Keyword arguments referenced as a variable are hard to keep colocated with the actual assertion, and often drift away randomly
    • Especially when the analytics hash is defined outside the spec itself, e.g. as an RSpec let memoized variable, which is unnecessary as we usually ought to only assert the expected log result once in most cases, and the variable is not reused
  • Clearer separation of "Arrange Act Assert"
  • Fewer curly braces 😉
• Improves consistency
  • Some tests have mixed implementation of have_logged_event inline vs. referenced variable
• Encourages best practices
  • Sometimes a variable can be used to "DRY" up repeated log properties, but this should instead be a signal that we're redundantly logging the same thing multiple times and we should address the root problem.
  • Sometimes a variable can be used to avoid excessive indentation when used in combination with hash_including matching assertion, but I'm of the opinion that we should generally always assert exactly what we're expecting, as hash_including can often produce false sense of confidence when properties are added in the future without accountability to corresponding spec expectation changes.
• Code size
  • See "Additions" and "Removals" summary in changed files ("556 additions and 652 deletions" at time of writing)

Identified using a few search patterns in spec/ (usually filtered to spec/controllers and spec/features):

• have_logged_event\('.+?[^'):]\)
• (analytics_hash|properties|attributes|result) = \{

📜 Testing Plan

Verify tests pass.

[zachmargolis]

BIG FAN. LGTM

[aduth]

Noting that I based this branch off the one in #10987 to save myself some merge conflict headaches, so will have to wait 'til that one wraps up before merging.