Deploy RC 402 to Production#11014
Merged
zachmargolis merged 13 commits intostages/prodfrom Aug 1, 2024
Merged
Conversation
* Reorder backup codes to be last option * Use NUMBER_OF_CODES to avoid magic numbers * Reduce backup codes from 10 to 5 * Update description for backup code text * Add changelog changelog: User-Facing Improvements, Backup Codes, Deemphasize and reduce number of backup codes * Fix display of odd number backup codes in setup * Avoid persisting codes to database * Fix hard-coded references to 10 codes * Interpolate spelled-out backup codes count * Revert to 10 backup codes * Fix 10 spelled out in French Forgot to save! * Force string numeric for Chinese spelled-out numbers * Mark strings used * Interpolate numbers spelled out as string Avoid type issues with NUMBER_OF_CODES being numeric, but typical usage of t expecting string key * Stub faked string for odd number of codes * Use humanize gem with service class to convert readable numbers See: #10970 (comment) * Swap humanize with numbers_and_words More languages, possible future use-case of gendered numbers * Avoid mutating reference of available_locales * Use condition for control flow See: #10970 (comment) Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Add plurals rules **Why**: The numbers_and_words gem forces the I18n::Backend::Pluralization which requires locales to have plural rules defined, so this commit adds those rules --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Zach Margolis <zachary.margolis@gsa.gov>
#10978) * Avoid new device email for reauthentication from new account changelog: Upcoming Features, Aggregated Sign-in Emails, Avoid new device email for reauthentication from new account * Refine spec description * Set new device session value at account initialization
changelog: Internal, Maintenance, Update Ruby dependencies
…is English (#10994) * display newer post-completion survey to users whose locale is English * update email survey feature specs to account for email locale * Changelog: User-Facing Improvements, In-person Proofing, Display newer survey in English-language completion emails
* LG-13580 Update voice call script for 10-digit OTP We received new translations for these scripts including new words for "digit" and "characters". This commit puts the new translations in place. [skip changelog]
When the GPO option is available the verify-by-phone rate limit screen contains the following: > For security reasons, we limit the number of times you can attempt to verify your phone number online. > > You can: > - Verify by mail, which takes 5 to 10 days > - Cancel and start over again after 5 hours and 59 minutes However, when the verify-by-mail option is not available this list only contains one bullet point. This commit removes the list when there is no verify by mail option. It introduces a paragraph to tell the user to try again after the rate limit expires. [skip changelog]
* LG-13408 Standardize logging for opted in ipp true/false changelog: Internal, In-person proofing, Standardize logging for opted in ipp true/false values
* Assert logged events using have_logged_event changelog: Internal, Automated Testing, Assert logged events using have_logged_event * Reshuffle have_logged_event after action that logs * Remove unnecessary pii_like_keypaths stub expectatino * Fix phone spec stub setup for NewPhoneForm * Ensure event always created before running disavowal specs Previously, the event only existed by the time the action was called since it was referenced in the stubs setup before the action call. Now the assertion happens after, so the event has to be created elsewise. * Restore accidental action removal / shuffle * Document missing analytics properties flagged by FakeAnalytics * Remove redundant conflicting stub on Analytics#track_event * Reshuffle have_logged_event after action that logs * Remove unnecessary allowed_extra_analytics * Remove redundant conflicting stub on Analytics#track_event * Reshuffle have_logged_event after action that logs
changelog: Internal, Continuous Integration, Use ECR for Redis and Postgres images
* Assert logged events using have_logged_event (part 2) changelog: Internal, Automated Testing, Assert logged events using have_logged_event * Remove unnecessary allowed_extra_analytics
* remove getActualAcuantCamera method * remove getActualAcuantJavascriptWebSdk function * remove legacy acuant tests * remove getActualAcuantCameraUI * add changelog changelog: Internal, Doc Auth, remove code from outdated Acuant versions
changelog: Internal, Biometric Comparison, Clean up old, unused methods
* LG-13672 Update barcode page to add alert and remove a line changelog: User-Facing Improvements, In-person proofing, Barcode page updates to add alert and remove a line
zachmargolis
requested review from
Sgtpluck,
aduth,
eileen-nava,
jennyverdeyen,
jmhooper,
mitchellhenke and
theabrad
Contributor
Can we remove the words "and reduce number of" from this? I'd updated the PR title, but didn't revise the commit message for the changelog. |
aduth
approved these changes
Aug 1, 2024
Contributor
Author
done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Internal
Upcoming Features