Assert logged events using have_logged_event (part 2)#11010
Merged
Conversation
changelog: Internal, Automated Testing, Assert logged events using have_logged_event
mitchellhenke
approved these changes
Jul 31, 2024
mitchellhenke
pushed a commit
that referenced
this pull request
Jul 31, 2024
* Assert logged events using have_logged_event (part 2) changelog: Internal, Automated Testing, Assert logged events using have_logged_event * Remove unnecessary allowed_extra_analytics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates specs to replace
expect(@analytics).to receive(:track_event).withwith equivalentexpect(@analytics).to have_logged_event.This follows #11001, and includes updating some of the more involved analytics stubbing.
Why?
have_logged_eventincludes a number of additional helpers implemented through theFakeAnalyticsclass:📜 Testing Plan
Verify build passes.
Verify that there are no lingering references to stubbed
:track_eventforAnalyticsclass in thespec/directory.