LG-13985: Avoid new device email for reauthentication from new account#10978
Merged
LG-13985: Avoid new device email for reauthentication from new account#10978
Conversation
changelog: Upcoming Features, Aggregated Sign-in Emails, Avoid new device email for reauthentication from new account
aduth
changed the title
jmdembe
approved these changes
Jul 30, 2024
mdiarra3
approved these changes
Jul 30, 2024
mitchellhenke
pushed a commit
that referenced
this pull request
Jul 31, 2024
#10978) * Avoid new device email for reauthentication from new account changelog: Upcoming Features, Aggregated Sign-in Emails, Avoid new device email for reauthentication from new account * Refine spec description * Set new device session value at account initialization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-13985
🛠 Summary of changes
Fixes an issue with aggregated new device sign-in email notifications to avoid sending an email when a user reauthenticates during the same session they created their account.
📜 Testing Plan
reauthn_windowto a low value inconfig/application.ymlto facilitate testingBefore: "New sign-in and authentication with your Login.gov account" email is sent
After: "New sign-in and authentication with your Login.gov account" email is not sent