Skip to content

LG-13672 Update barcode page to add alert and remove a line#11005

Merged
jennyverdeyen merged 2 commits intomainfrom
jverdeyen/LG-13672-barcode-page-emailed-alert
Jul 31, 2024
Merged

LG-13672 Update barcode page to add alert and remove a line#11005
jennyverdeyen merged 2 commits intomainfrom
jverdeyen/LG-13672-barcode-page-emailed-alert

Conversation

@jennyverdeyen
Copy link
Copy Markdown
Contributor

@jennyverdeyen jennyverdeyen commented Jul 30, 2024

🎫 Ticket

Link to the relevant ticket:
LG-13672

🛠 Summary of changes

Updates IPP and EIPP barcode pages to have a new alert at the top, and removes the line "We have sent this information to the email you used to sign in." from the bottom.

📜 Testing Plan

IPP Barcode page

  • Enter the IPP flow - Through the Sinatra app, select Biometric for level of service and sign in.

  • Complete the IPP flow and arrive at the verify/in_person/ready_to_verify page.

  • Verify that there is a success alert at the top of the page that reads:Screenshot 2024-07-30 at 2 20 01 PM

    • En: We have sent your barcode and the information below to the email you used to sign in
    • Es: Enviamos el código de barras y la información más abajo al correo electrónico que usó para iniciar sesión
    • Fr: Nous avons envoyé votre code-barre et les informations ci-dessous à l’adresse e-mail que vous avez utilisée pour vous connecter
    • Ch: 我们已将条形码和以下信息发到了您用来登录的电邮地址
  • Verify that there is no line near the bottom of the page that reads "We have sent this information to the email you used to sign in" - it used to exist here:

Screenshot 2024-07-30 at 2 06 22 PM

EIPP Barcode page

  • Enter the EIPP flow - Through the Sinatra app, select Enhanced for level of service and sign in.
  • Complete the EIPP flow and arrive at the verify/in_person/ready_to_verify page.
  • Verify that there is a success alert at the top of the page that reads:Screenshot 2024-07-30 at 2 20 01 PM
    • En: We have sent your barcode and the information below to the email you used to sign in
    • Es: Enviamos el código de barras y la información más abajo al correo electrónico que usó para iniciar sesión
    • Fr: Nous avons envoyé votre code-barre et les informations ci-dessous à l’adresse e-mail que vous avez utilisée pour vous connecter
    • Ch: 我们已将条形码和以下信息发到了您用来登录的电邮地址
  • Verify that there is no line near the bottom of the page that reads "We have sent this information to the email you used to sign in" - it used to exist here:
Screenshot 2024-07-30 at 2 06 22 PM

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

IPP Barcode Page:

Barcode page (en)
Barcode page (es)
Barcode page (fr)
Barcode page (zh)

EIPP Barcode Page:

EIPP Barcode page (en)
EIPP Barcode page (es)
EIPP Barcode page (fr)
EIPP Barcode page (zh)

@jennyverdeyen jennyverdeyen changed the title LG-13590 Update barcode page to add alert and remove a line LG-13672 Update barcode page to add alert and remove a line Jul 30, 2024
changelog: User-Facing Improvements, In-person proofing, Barcode page updates to add alert and remove a line
@jennyverdeyen jennyverdeyen force-pushed the jverdeyen/LG-13672-barcode-page-emailed-alert branch from 4eeeb63 to e26a735 Compare July 30, 2024 18:29
@jennyverdeyen jennyverdeyen requested review from a team, eileen-nava and rutvigupta-design and removed request for a team July 30, 2024 18:31
Copy link
Copy Markdown
Contributor

@KeithNava KeithNava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Copy Markdown

@rutvigupta-design rutvigupta-design left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@gina-yamada gina-yamada self-requested a review July 31, 2024 15:05
Copy link
Copy Markdown
Contributor

@gina-yamada gina-yamada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the alert added on the Ready to Verify view and the one line removed for both IPP and EIPP (matches mocks) locally. No changes were made to the Ready to Verify email. I inspected all languages and mobile- all as I'd expect. I confirmed, no other instances of in_person_proofing.body.barcode.email_sent found so changing the content will not affect other views.

LGTM! Nice work @jennyverdeyen

@jennyverdeyen jennyverdeyen merged commit 76cfc2c into main Jul 31, 2024
@jennyverdeyen jennyverdeyen deleted the jverdeyen/LG-13672-barcode-page-emailed-alert branch July 31, 2024 16:02
mitchellhenke pushed a commit that referenced this pull request Jul 31, 2024
* LG-13672 Update barcode page to add alert and remove a line

changelog: User-Facing Improvements, In-person proofing, Barcode page updates to add alert and remove a line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants