LG-13672 Update barcode page to add alert and remove a line#11005
Merged
jennyverdeyen merged 2 commits intomainfrom Jul 31, 2024
Merged
LG-13672 Update barcode page to add alert and remove a line#11005jennyverdeyen merged 2 commits intomainfrom
jennyverdeyen merged 2 commits intomainfrom
Conversation
changelog: User-Facing Improvements, In-person proofing, Barcode page updates to add alert and remove a line
4eeeb63 to
e26a735
Compare
gina-yamada
reviewed
Jul 31, 2024
gina-yamada
approved these changes
Jul 31, 2024
Contributor
There was a problem hiding this comment.
I can see the alert added on the Ready to Verify view and the one line removed for both IPP and EIPP (matches mocks) locally. No changes were made to the Ready to Verify email. I inspected all languages and mobile- all as I'd expect. I confirmed, no other instances of in_person_proofing.body.barcode.email_sent found so changing the content will not affect other views.
LGTM! Nice work @jennyverdeyen
15 tasks
mitchellhenke
pushed a commit
that referenced
this pull request
Jul 31, 2024
* LG-13672 Update barcode page to add alert and remove a line changelog: User-Facing Improvements, In-person proofing, Barcode page updates to add alert and remove a line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-13672
🛠 Summary of changes
Updates IPP and EIPP barcode pages to have a new alert at the top, and removes the line "We have sent this information to the email you used to sign in." from the bottom.
📜 Testing Plan
IPP Barcode page
Enter the IPP flow - Through the Sinatra app, select Biometric for level of service and sign in.
Complete the IPP flow and arrive at the
verify/in_person/ready_to_verifypage.Verify that there is a success alert at the top of the page that reads:
Verify that there is no line near the bottom of the page that reads "We have sent this information to the email you used to sign in" - it used to exist here:
EIPP Barcode page
verify/in_person/ready_to_verifypage.👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
IPP Barcode Page:
EIPP Barcode Page: