LG-13699: Display newer post-completion survey to users whose locale is English#10994
Merged
eileen-nava merged 4 commits intomainfrom Jul 30, 2024
Merged
LG-13699: Display newer post-completion survey to users whose locale is English#10994eileen-nava merged 4 commits intomainfrom
eileen-nava merged 4 commits intomainfrom
Conversation
eileen-nava
changed the title
…r survey in English-language completion emails
eileen-nava
force-pushed
the
em/13699-modify-ipp-followup-email
branch
from
1c02b8c to
b714755
Compare
eileen-nava
commented
Jul 29, 2024
eileen-nava
requested review from
a team and
WheresHJ
and removed request for
a team
shanechesnutt-ft
approved these changes
Jul 29, 2024
Contributor
shanechesnutt-ft
left a comment
shanechesnutt-ft
left a comment
There was a problem hiding this comment.
Changes look good to me! Good work! 👍🏻
|
Reviewed in person with @eileen-nava. LGTM! |
mitchellhenke
pushed a commit
that referenced
this pull request
Jul 31, 2024
…is English (#10994) * display newer post-completion survey to users whose locale is English * update email survey feature specs to account for email locale * Changelog: User-Facing Improvements, In-person Proofing, Display newer survey in English-language completion emails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-13699: Implementation: Modify IPP follow up email with new survey link
🛠 Summary of changes
📜 Testing Plan
To test the email for English language users:
http://localhost:3000/rails/mailers/user_mailer/in_person_completion_surveyTo ensure that there are no regressions introduced for Chinese/French/Spanish language users:
http://localhost:3000/rails/mailers/user_mailer/in_person_completion_survey👀 Screenshots
I didn't include screenshots for design review because the email's visual appearance has not changed. I would be happy to jump on a call and screenshare with a designer while they do design review.