Merged
Conversation
See https://gitlab.login.gov/lg-people/lg-people-appdev/Melba/backlog-fy24/-/issues/37 **Why**: Network errors encountered when posting RISC events result in a lot of noise in NewRelic. They are not of much value in NewRelic as they are also logged as risc_security_event_pushed events. **How**: Don't bubble up the network errors. Do nothing when GoodJob exhausts its reties. changelog: Internal, Error handling, Remove RISC network errors from NewRelic
* changelog: Upcoming Features, In-person proofing, create enhanced ipp enrollments * fix broken tests * fix broken test and remove extraneous tests * fix broken spec * change enhanced_ipp to is_enhanced_ipp * fix lint error * update mock proofer to allow confirmation of enhanced ipp on barcode page * refactor enrollment helper schedule_in_person_enrollment method to use keyword arguments * test that non-enhanced ipp enrollments retain the expected sponsor id and IPPAssuranceLevel
changelog: Internal, ResolutionProofingJob, Populate ssn_is_unique
…er (#10796) Prior to this commit we have been passing `should_proof_state_id` from the `VerifyInfoConcern` down to the `ProgressiveProofer` through the async proofing tooling. This requires this argument to be passed down the call stack and stored as a background job argument. The `should_proof_state_id` value is determined by configuration that is available to the IdP and the workers. It is not clear why it needs to be computed in the `VerifyInfoConcern` and passed down through the job to the `ProgressiveProofer`. This commit shortcuts everything by moving the logic closer to where the value is actually inspected. [skip changelog]
* Setup Ready to Verify Email for condi EIPP * Style in_person_ready_to_verify mailer template * Pass in eval if eipp to decide which email temp * Rename variable from is_eipp to is_enhanced_ipp * fix specs and linter errors * Remove arg defaults, update specs * fix linter errors * Restore file, modify comment * Update test description and comment * pass in default for gpo verify form * add spec user_mailer_preview, handle both cases * Update specs to pass in addi variable * Update var passing into method, new spec * fix specs and linter errors * Add mailer specs to test template content * pass in var rather than hard code for gpo flow * changelog: Upcoming Features, Enhanced In-person Proofing, Conditionally render Enhanced IPP version of Ready To Verify Email. Enhanced IPP Email template has additional content and a different design. * show Ready to Verify email w/ eipp as true * Simplify specs by aggregating failures * simplify ready to veri show spec w/ aggr failure * fix linter errors * Add padding to bottom ready to verify * Rename describe block * Update spec test descriptions
* Update zh.yml * Update missing Chinese translations changelog: Internal, Translations, Update missing Chinese translations --------- Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
) The workflow completed section of the identity verification report describes the state a user is in when completing the proofing workflow. That has the dimensions: - Fraud review pending: The user may or may not be fraud review pending - GPO pending: The user may or may not be waiting on a letter - In-person pending: The user may or may not need to proof in person A user can have all, none, or some combination of these when completing the workflow. Previously the workflow steps did not account for all of the possible cases. This commit updates the report to lay out the counts for each possible case. [skip changelog]
* Schedule weekly reports to run Monday for the previous week Our jobs use the default Rails definition of a week starting on a Monday. I think this is the ISO standard. Running a job on Monday and giving it the argument `Time.zone.yesterday` means that weekly jobs will process data for the previous week changelog: Internal, Reporting, Move weekly reports to run at 00:00 Monday UTC * Update job config spec based on PR feedback Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> changelog: Internal, Reporting, Move weekly reports to run at 00:00 Monday UTC --------- Co-authored-by: Howard M. Miller <3620291+h-m-m@users.noreply.github.com>
The `VerifyInfoConcern` used to add SP costs to the database by inspecting the result from the `ResolutionProofingJob`. We have made the following changes in an effort to move the logic for tracking SP costs into the resolution proofing job: - In #10743 we added a conditional to the `VerifyInfoConcern` to stop writing SP costs if a `sp_costs_added` flag is present on the result - In #10767 we started adding costs in the `ResolutionProofingJob` and had the job set the `sp_costs_added` flag - In #10786 we removed the code that added the SP costs in the `VerifyInfoConcern` This commit includes the changes for the final step: Removing the `sp_costs_added` flag now that nothing is reading it. This commit can be safely merged into main when all of the above changes are fully deployed. [skip changelog]
Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.11.3 to 1.11.4. - [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md) - [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.11.3...v1.11.4) --- updated-dependencies: - dependency-name: libphonenumber-js dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* changelog: User-Facing Improvements, identity verification, Verified & Pending States for Identity Verification * add badges pertaining to verification status * add tooltip enabled component * add biometric verification to verified account view * add translated text * remove redundant key * change tooltip to use mouseover * clarify tooltip js and add testing * add spec for badge tooltip * move styling to badge tooltip * add readme to package * sync application.yml.default for missing keys * updated yarn.lock * fix errors in yml * normalize yml * post yarn install * pinpoint countries * yarn... lock * re-normalize yaml country codes * fix lint errors in badge scss's * remove unused keys * replace missing translation key * remove hardcoded app_name from translations * fix inconsistencies in verified button styling * remove unneeded css * add view tests for new badge placement
* Update zh.yml for IDV * Update zh.yml for IDV changelog: Internal, Translations, Update Chinese translations * Delete a typo
changelog: Internal, Translations, Update Chinese translations
Contributor
This can be removed from the release notes. Edit: Edited just as I was leaving the comment 😅 |
aduth
approved these changes
Jun 20, 2024
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Question in Slack about a potential issue with #10816, but LGTM otherwise 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal
Upcoming Features