LG-12603 Verified & Pending States for Identity Verification#10823
LG-12603 Verified & Pending States for Identity Verification#10823kevinsmaster5 merged 26 commits intomainfrom
Conversation
…& Pending States for Identity Verification
kevinsmaster5
force-pushed
the
kmas-lg-12603-verified-pending-states
branch
from
75123e2 to
cfd4dd6
Compare
| this.badge = this.querySelector('.usa-tooltip')!; | ||
|
|
||
| this.setUpTooltip(); | ||
| this.badge.addEventListener('mouseover', () => this.handleHover()); |
There was a problem hiding this comment.
How does someone access the tooltip content if they're using a keyboard or screen reader?
There was a problem hiding this comment.
I'm not sure, should those be tab-focusable? It seemed like from Kamal's comment they would only be a hover
https://www.figma.com/design/RbqHzdFNiCMTXSKSBOqwYX?node-id=4482-9726#769800201
It leaves Mobile out of the picture also.
There was a problem hiding this comment.
The way I would expect it to work is that the badge is focusable (which it is currently), and that the tooltip is visible as long as the badge has focus. In addition to the current hover behavior.
| margin-right: units(1); | ||
| } | ||
|
|
||
| .border-warning { |
There was a problem hiding this comment.
.border-warning already exists, as implemented by the design system, so I don't think we need to duplicate it here, and I wouldn't expect the utility class to customize icon or text color.
Instead, I think we could apply classes border-warning text-warning on the HTML elements and avoid this additional CSS altogether.
|
|
||
| def show_pii_partial? | ||
| decrypted_pii.present? || user.identity_verified? | ||
| decrypted_pii.present? || user.identity_verified? unless |
There was a problem hiding this comment.
Can we add test coverage for these changes?
| if user.identities.count == 0 | ||
| APP_NAME | ||
| else | ||
| user.identities.last.friendly_name |
There was a problem hiding this comment.
Do we have any guarantees that this is the name of the service provider that the user was trying to access for identity verification, as opposed to another partner application that the user is authenticated with (at IAL1) ?
| <% else %> | ||
| <p> | ||
| <%= t('account.index.verification.finish_verifying', partner_agency: @presenter.service_provider_or_app_name) %> | ||
| <br><%= link_to t('account.index.verification.learn_more_link'), MarketingSite.help_url %> |
There was a problem hiding this comment.
Were these supposed to go to a specific Help Center article?
3 participants
🎫 Ticket
Link to the relevant ticket:
LG-12603
🛠 Summary of changes
Creates a wrapper component to provide a tooltip-interactive element to Verified status badges and implement on account view. Adds logic to account view that determines what sort of "Verified" type badge to show based on the user's verification status: Pending, Unverified( but previously verified ), and Verified. It also factors in users that are verified by way of Biometric verification.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
👀 Screenshots
Verified user
Verified user
(with biometric)
Unverified
(by way of reset password on formerly verified account)
Pending
(IPP)
Pending
(GPO)
