LG-13245: create enhanced ipp enrollment#10820
Merged
eileen-nava merged 11 commits intomainfrom Jun 17, 2024
Merged
Conversation
…e keyword arguments
gina-yamada
reviewed
Jun 17, 2024
gina-yamada
reviewed
Jun 17, 2024
Contributor
|
@eileen-nava Do you have a plan to test this in staging once merged in to confirm that the enrollment is EIPP? (ie How do you know this is an EIPP enrollment? At this stage- is it just a successful enrollment until we complete LG-13577? |
eileen-nava
commented
Jun 17, 2024
… and IPPAssuranceLevel
gina-yamada
approved these changes
Jun 17, 2024
Contributor
There was a problem hiding this comment.
Code changes look good. Thank for refactoring a few places to take key word args and for updating EIPP to Enhanced IPP.
I observed enrollment code “3141-59” when I created an EIPP enrollment (coming in from Sinatra) on the Ready to Verify view and email. I observed the longer barcode enrollment code on Ready to Verify view and email testing locally.
LGTM! 💯
This was referenced Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




🎫 Ticket
LG-13245: Consume EIPP Data Supplied by Sinatra App in idp to Create an EIPP Enrollment
🛠 Summary of changes
📜 Testing Plan