Remove the sp_costs_added flag from the resolution result#10792
Merged
Remove the sp_costs_added flag from the resolution result#10792
sp_costs_added flag from the resolution result#10792Conversation
jmhooper
force-pushed
the
jmhooper-remove-verify-info-cost-tracking
branch
from
fdc5f22 to
e3113e9
Compare
jmhooper
force-pushed
the
jmhooper-remove-sp-costs-added
branch
from
e303edc to
3a3825d
Compare
matthinz
approved these changes
Jun 11, 2024
Base automatically changed from
jmhooper-remove-verify-info-cost-tracking
to
main
June 13, 2024 13:45
jmhooper
force-pushed
the
jmhooper-remove-sp-costs-added
branch
from
3a3825d to
a73e3b7
Compare
The `VerifyInfoConcern` used to add SP costs to the database by inspecting the result from the `ResolutionProofingJob`. We have made the following changes in an effort to move the logic for tracking SP costs into the resolution proofing job: - In #10743 we added a conditional to the `VerifyInfoConcern` to stop writing SP costs if a `sp_costs_added` flag is present on the result - In #10767 we started adding costs in the `ResolutionProofingJob` and had the job set the `sp_costs_added` flag - In #10786 we removed the code that added the SP costs in the `VerifyInfoConcern` This commit includes the changes for the final step: Removing the `sp_costs_added` flag now that nothing is reading it. This commit can be safely merged into main when all of the above changes are fully deployed. [skip changelog]
jmhooper
force-pushed
the
jmhooper-remove-sp-costs-added
branch
from
a73e3b7 to
436b75a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
VerifyInfoConcernused to add SP costs to the database by inspecting the result from theResolutionProofingJob. We have made the following changes in an effort to move the logic for tracking SP costs into the resolution proofing job:VerifyInfoConcernto stop writing SP costs if asp_costs_addedflag is present on the resultProgressiveProoferclass #10767 we started adding costs in theResolutionProofingJoband had the job set thesp_costs_addedflagVerifyInfoConcern#10786 we removed the code that added the SP costs in theVerifyInfoConcernThis commit includes the changes for the final step: Removing the
sp_costs_addedflag now that nothing is reading it.This commit can be safely merged into main when all of the above changes are fully deployed.