LG-13196 Enhanced IPP Ready to Verify Email#10816
Conversation
…96-EIPP-Ready-To-Verify-Email
…lly render Enhanced IPP version of Ready To Verify Email. Enhanced IPP Email template has additional content and a different design.
|
@gina-yamada this looks great! I noticed two tiny things:
|
For the EIPP email: Check out the image below. The red vertical line has a padding of 2 rem. Let me know if you want to inspect while running or if you meant a different spot.For the IPP email: I missed the padding. I added it- check out the screenshots below. The form is the same template. If I add padding to one section for one view (EIPP) it can affect the other (IPP) view. That is why I decided to take screenshots of both the IPP version and EIPP version.SpanishFrenchChinese |
|
@gina-yamada thanks so much for confirming the EIPP padding and fixing the padding in the IPP email! Translations and everything LGTM! 🎉 |
eileen-nava
left a comment
There was a problem hiding this comment.
Approved. 👏🏻 I left some non-blocking feedback.
| .border-top-width-0 { | ||
| border-top: 0; | ||
| } |
There was a problem hiding this comment.
The other utilities in this file follow from USWDS. AFAIK, border-top-width-0 doesn't exist in USWDS. But border-top-0 does.
| .border-top-width-0 { | |
| border-top: 0; | |
| } | |
| .border-top-0 { | |
| @include u-border-top(0); | |
| } |
| <table class="margin-bottom-3"> | ||
| <tbody> | ||
| <tr> | ||
| <td align="left" width="110.46px"> |
There was a problem hiding this comment.
td width is deprecated, and I don't think it expected units to be provided (hard to verify since the spec doesn't document the attribute anymore)
| <td align="left" width="110.46px"> | ||
| <%= image_tag( | ||
| asset_url('idv/state-id-and-passport.svg'), | ||
| width: 110.46, |
There was a problem hiding this comment.
I'm not sure subpixel values are valid, or at least might behave unpredictably. Might have suggested rounding down with these values.
|
@rutvigupta-design This has been merged into production. The EIPP email will not be viewable in production though- only in staging. |
|
Thanks so much @gina-yamada! Since we've already sent the app version of this to DOS for LQA, we can skip sending this to them since the content is the same but I'll update our tracker for posterity :) |













🎫 Ticket
LG-13196 Implementation: EIPP "You're ready to verify in person" Barcode email
🛠 Summary of changes
is_eipptois_enhanced_ippas agreed on by team (see Slack thread) -- This should have no affect on the Ready to Verify View but please confirm nothing broke as a resultNotice: The Ready to Verify Email Reminder will be handled in LG-13606.
📜 Testing Plan
To inspect the template for design and content
Then pick:
in_person_ready_to_verifyand you change languages via the drop down in the top left (to confirm existing behavior is working as expected)Then pick:
in_person_ready_to_verify_enhanced_ipp_enabledand you change languages via the drop down in the top left (to confirm new behavior is working as expected)Confirm the Ready to Verify Email for IPP is not affected
http://localhost:3000/rails/mailers/user_mailer/in_person_ready_to_verifyInspect the Ready to Verify Email for EIPP to approve template and content
http://localhost:3000/rails/mailers/user_mailer/in_person_ready_to_verify_enhanced_ipp_enabledhttp://localhost:3000/rails/mailers/user_mailer/in_person_ready_to_verify_reminderand confirm that the ready to verify reminder email is not affected. It should look like the IPP template in step 6. It will be handled in LG-13606.To test the conditionally logic in the flow 🔴 please test this out 🔴
Confirm the IPP Flow Displays the Ready to Verify Email for IPP (Existing behavior is not affected)
Confirm the EIPP Flow Displays the Ready to Verify Email for EIPP (New behavior is working as expected)
👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
EIPP Ready to Verify **Email**
IPP Ready to Verify **Email** (To confirm existing email is not affected)
EIPP Ready to Verify **View** (To confirm existing view is not affected)
IPP Ready to Verify **View** (To confirm existing view is not affected)