Merged
Conversation
In #10767 we changed the `ProgressiveProofer` class to begin tracking SP costs closer to where costly events occur. The logic for tracking costs was left in the `VerifyInfoConcern` to deal with the 50/50 state. When the changes in #10767 are fully deployed this can be merged to clean up dead code. [skip changelog]
changelog: Internal, Tests, Small refactor to AnalyticsSpec
…ect. (#10762) * Extract defineObservableProperty into its own file * Add stopObservingProperty * Use stopObservingProperty in acuant-capture-canvas changelog: Bug Fixes, Acuant SDK, Clear out a callback when done with it. --------- Co-authored-by: John Maxwell <john.maxwell@gsa.gov> Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov> Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
In #10728 we started passing the service provider ID to the resolution proofing job. Since the job has the user ID this allows us to compute UUID and UUID prefix in the job instead of having to pass them through the applicant. Once that commit is deployed we can stop passing the UUID and UUID prefix via the applicant. This commit removes the code that looks up the UUID prefix and UUID and merges them into the applicant. This should not be merged until #10728 is fully deployed to production. [skip changelog]
I found some code referencing `address_edited` on the `AddressForm` response. We removed that so there is not reason to inspect it. This commit also does some touch-ups to the form and the controller to clean up the logic. [skip changelog]
**Why**: This is prep work that enables running these checks on a schedule on main branch, instead of on feature branches changelog: Internal, Tests, Reorganize dependency audit checks Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov> * Add "needs" clause for pinpoint-check job too --------- Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
[skip changelog]
* Add test to ensure schema files are consistent with migrations changelog: Internal, Continuous Integration, Add test to ensure schema files are consistent with migrations * move linting into Makefile
…10817) * fixing column name and order for billing report v2
changelog: Internal, Translations, Update missing Chinese translations
* Update email language preference to be translated into the lang being described. changelog: User-Facing Improvements, Account Page, Update language email preference selection to be in the language being described. * fix spec --------- Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
* changelog: Internal, Metrics, Add certificate validation errors to event
* changelog: CI, Internal, Cutover review-apps to new cluster
changelog: Internal, Continuous Integration, Add coverage metric to GitLab CI
…0822) /test/oidc/login. I found the existing SP failed with errors for me. This changes makes the links work again. Note: the test routes are disabled in production envs (i.e., deployed envs) [skip changelog]
mitchellhenke
approved these changes
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal