Skip to content

Update email language preference to its associated language#10808

Merged
juliasolorzano merged 2 commits intomainfrom
js-update-email-preference-translation
Jun 14, 2024
Merged

Update email language preference to its associated language#10808
juliasolorzano merged 2 commits intomainfrom
js-update-email-preference-translation

Conversation

@juliasolorzano
Copy link

@juliasolorzano juliasolorzano commented Jun 12, 2024

🛠 Summary of changes

Updating the language email preference is displayed in the language it is describing. This is similar practice in the language picker and should be consistent in both places.

Ref #10291 (comment)

@juliasolorzano juliasolorzano force-pushed the js-update-email-preference-translation branch from 296a913 to 5bc185f Compare June 12, 2024 18:53
@juliasolorzano juliasolorzano force-pushed the js-update-email-preference-translation branch from 5bc185f to dec632c Compare June 12, 2024 19:26
@mitchellhenke mitchellhenke force-pushed the js-update-email-preference-translation branch 2 times, most recently from 85b690b to 2753666 Compare June 14, 2024 16:07
Julia Solórzano and others added 2 commits June 14, 2024 11:10
… described.

changelog: User-Facing Improvements, Account Page, Update language email preference selection to be in the language being described.
@mitchellhenke mitchellhenke force-pushed the js-update-email-preference-translation branch from 2753666 to 7166fc7 Compare June 14, 2024 16:11
@juliasolorzano juliasolorzano merged commit 9c81a80 into main Jun 14, 2024
@juliasolorzano juliasolorzano deleted the js-update-email-preference-translation branch June 14, 2024 16:41
brandemix pushed a commit to brandemix/18F-identity-idp that referenced this pull request Jun 17, 2024
* Update email language preference to be translated into the lang being described.

changelog: User-Facing Improvements, Account Page, Update language email preference selection to be in the language being described.

* fix spec

---------

Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This likely needs additional markup changes to satisfy WCAG SC 3.1.2 Language of Parts. Currently, the account page will try to read "Español" as English.

Edit: Fix proposed in #10841

@aduth
Copy link
Contributor

aduth commented Jun 21, 2024

A potentially-unintended side effect of this is that the "Create an account" page lists out these language options in a sentence, which now show as translated in that language. I'd personally expect these would be using English name of the language when used in a sentence of English text. (Or at least similar to previous comment, using markup annotating language of parts)

Screenshot 2024-06-21 at 9 46 10 AM

@aduth
Copy link
Contributor

aduth commented Jul 16, 2024

A potentially-unintended side effect of this is that the "Create an account" page lists out these language options in a sentence, which now show as translated in that language. I'd personally expect these would be using English name of the language when used in a sentence of English text. (Or at least similar to previous comment, using markup annotating language of parts)

For posterity, this will be updated as part of LG-13728 and LG-13869 (content and implementation tickets, respectively).

The updated hint text will read "You will receive emails from Login.gov in the language you choose."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants