Merged
Conversation
Sgtpluck
commented
Jun 14, 2024
| # Logging to indicate if a validation bug fix will create a potentially breaking change | ||
| analytics_payload[:encryption_cert_matches_matching_cert] = | ||
| encryption_cert_matches_matching_cert? | ||
| analytics_payload[:cert_error_details] = saml_request.cert_errors |
Contributor
Author
There was a problem hiding this comment.
i thought about using the existing error_details key, since it should be empty if the request is successful. but i thought that could be confusing ultimately, so decided not to -- interested in thoughts about that!
Contributor
There was a problem hiding this comment.
it makes sense to me to keep separate!
Sgtpluck
commented
Jun 14, 2024
| matching_cert_serial:, | ||
| encryption_cert_matches_matching_cert:, | ||
| } | ||
| end |
Contributor
Author
There was a problem hiding this comment.
i removed this to make the result conditions more explicit in the individual tests
zachmargolis
approved these changes
Jun 14, 2024
Sgtpluck
force-pushed
the
dmm/add-saml-cert-error-logging
branch
from
93ed624 to
99e7dde
Compare
brandemix
pushed a commit
to brandemix/18F-identity-idp
that referenced
this pull request
Jun 17, 2024
* changelog: Internal, Metrics, Add certificate validation errors to event
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://gitlab.login.gov/lg-people/lg-people-appdev/Melba/backlog-fy24/-/issues/42
🛠 Summary of changes
cert_error_detailsto log specific certificate errors if the request is signed and successful