Remove dead code in the Idv::AddressController#10811
Merged
Conversation
I found some code referencing `address_edited` on the `AddressForm` response. We removed that so there is not reason to inspect it. This commit also does some touch-ups to the form and the controller to clean up the logic. [skip changelog]
zachmargolis
approved these changes
Jun 13, 2024
brandemix
pushed a commit
to brandemix/18F-identity-idp
that referenced
this pull request
Jun 17, 2024
I found some code referencing `address_edited` on the `AddressForm` response. We removed that so there is not reason to inspect it. This commit also does some touch-ups to the form and the controller to clean up the logic. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found some code referencing
address_editedon theAddressFormresponse. We removed that so there is not reason to inspect it.This commit also does some touch-ups to the form and the controller to clean up the logic.