Skip to content

Update db/schema.rb to match migrations#10815

Merged
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/fix-db-schema-2
Jun 13, 2024
Merged

Update db/schema.rb to match migrations#10815
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/fix-db-schema-2

Conversation

@mitchellhenke
Copy link
Copy Markdown
Contributor

🛠 Summary of changes

#10759 included db/schema.rb changes that differed slightly from the result of running migrations.

# These are extensions that must be enabled in order to support this database
enable_extension "citext"
enable_extension "pg_stat_statements"
enable_extension "pgcrypto"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mitchellhenke mitchellhenke merged commit 4452ab3 into main Jun 13, 2024
@mitchellhenke mitchellhenke deleted the mitchellhenke/fix-db-schema-2 branch June 13, 2024 20:51
brandemix pushed a commit to brandemix/18F-identity-idp that referenced this pull request Jun 17, 2024
t.boolean "ready_for_status_check", default: false
t.datetime "notification_sent_at", comment: "The time a notification was sent"
t.datetime "last_batch_claimed_at"
t.string "sponsor_id", comment: "The identification number for USPS to recognize us and our flow (ex: Enhanced IPP)"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment was intentionally added based on review feedback, so the sync-up should probably have been to include the comment in the migration itself.

cc @KeithNava @eileen-nava

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment won't appear in the database in environments that have already run this migration, and I'm not sure how often we update migrations that have already been run (though a comment is maybe not over that line)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I suppose if it's important to have the comment, a separate migration just to add the comment might be the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants