Merged
Conversation
* remove response argument form extract_pii_from_doc * take pii from DocumentCaptureSessionResult instead of assuming it's a DocAuth::Response * [skip changelog] * pii_from_doc is an alias * rename to stored_result * remove unnecessary document_capture_session_result method
… SP is present (#10092) Currently when there is no SP present `ApplicationController#resolved_authn_context_result` raises an error when it tries to resolve an Authn Context without a VoT or ACR values. This creates an issue when this method is called outside the context of a service provider request. In order to let the method be called outside of an SP context this commit introduces a no-SP result which can be returned when no SP is present. This allows the method to be called and requirements for authentication and identity-verification to be inspected without a service provider. This method opts to base the conditional on whether an SP is present rather than whether ACR values or a VoT is present. This preserves behavior where a missing ACR value and VoT will cause an error to be raised. In the case where those values are missing and an SP is present we want to raise an error rather than proceeding with a no-SP result. [skip changelog]
Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.10.55 to 1.10.56. - [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md) - [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.10.55...v1.10.56) --- updated-dependencies: - dependency-name: libphonenumber-js dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
changelog: Internal, Error Logging, Ignore frontend errors not originating from application script
changelog: Internal, Analytics, Remove fallback logging for unknown frontend event
…ranslated (#9997) changelog: Internal, Bug Fixes, Fix static usage of error messages that results in them not being untranslated
….json (#9959) * Parallelize feature spec build * Leverage Make up-to-date for browsers.json changelog: Internal, Build Tooling, Improve performance of JavaScript build
* Guarantee uniqueness of auth app factory name changelog: Internal, Automated Testing, Improve reliability of fake data in automated testing * Improve uniqueness of PIV configuration factory
* Reimplement icon component as SVG image mask changelog: Internal, Performance, Reduce download size for icon images * Remove unused images * Permit nonce for style-src CSP directive * Update CSP specs * Move static inline styles to stylesheet * Memoize icon_path Multiple calls per render * Update IconComponent specs * Revise link matcher to check text Previous assertion used XPath, where XPath text matchers don't correctly ignore inline style tag contents * Update IconListComponent specs * Render IconComponent inline style as direct string content Since it's already rendered as simple string, pass as argument in content_tag. Also avoids excess whitespace * Add method parenthesis For clarity, avoid ambiguity with "and" keyword Co-authored-by: Zach Margolis <zachary.margolis@gsa.gov> * Trim whitespace in icon component output Significant for use in ButtonComponent --------- Co-authored-by: Zach Margolis <zachary.margolis@gsa.gov>
…rt (#10100) * LG-12065 Add "full registered users count" to Monthly Key Metric Report changelog: Internal, Reporting, Add count of fully registered users in Total User table * Update app/services/reporting/total_user_count_report.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Update app/services/reporting/total_user_count_report.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * specs * Update app/services/reporting/total_user_count_report.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * lint --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* add vtr and acr_values to identity table * update db schema [skip changelog]
…gration usages or iaa orders (#10106)
…on is successful (#10099) changelog: Bug Fixes, Document Authentication, Attention with Barcode only when image upload is successful"
changelog: Internal, Performance, Reduce number of image assets loaded in common layout
changelog: Internal, Database, Drop unused monthly_auth_counts table
…10017) Add consistent troubleshooting link styles changelog: User-Facing Improvements, Registration, Make troubleshooting links consistent with other modules
* changelog: User-Facing Improvements, Authentication, send text message when user deletes their account * address comments and only send text if it supports the capability and confirmed * change to sms * configuration * move to deliver now * add back linter
zachmargolis
approved these changes
Feb 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal