Skip to content

Drop unused monthly_auth_counts table (LG-12483)#10109

Merged
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/drop-monthly-auth-counts-table
Feb 20, 2024
Merged

Drop unused monthly_auth_counts table (LG-12483)#10109
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/drop-monthly-auth-counts-table

Conversation

@mitchellhenke
Copy link
Contributor

🎫 Ticket

Link to the relevant ticket:
LG-12483

🛠 Summary of changes

We stopped using this table in #3634, and that PR created monthly_sp_auth_counts. That table was dropped in #7312. Along similar lines, this PR drops the monthly_auth_counts table.

Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog: Internal, Database, Drop unused monthly_auth_counts table
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/drop-monthly-auth-counts-table branch from 317049b to 6b4a2b2 Compare February 20, 2024 14:23
@mitchellhenke
Copy link
Contributor Author

Should we remove the model as well?

https://github.com/18F/identity-idp/blob/main/app/models/monthly_auth_count.rb

Thanks for catching that. I made a note of it, but totally forgot.

@mitchellhenke mitchellhenke merged commit 20f08b3 into main Feb 20, 2024
@mitchellhenke mitchellhenke deleted the mitchellhenke/drop-monthly-auth-counts-table branch February 20, 2024 14:47
@zachmargolis
Copy link
Contributor

I think we need to remove the model in a PR before the table because we have our code set up to eager connect to tables? it's a benign error if it pops up during a deploy though

@mitchellhenke
Copy link
Contributor Author

I think we need to remove the model in a PR before the table because we have our code set up to eager connect to tables? it's a benign error if it pops up during a deploy though

Do you have a link to that error happening in the past? I tested locally and in the sandbox and the deploy seems to work ok.

@zachmargolis
Copy link
Contributor

I don't offhand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants