LG-12428: extract_pii_from_doc refactor#10069
Merged
Conversation
amirbey
force-pushed
the
amirbey/LG-12370-extract-pii-from-doc-cleanup
branch
from
7ea232b to
247370d
Compare
amirbey
changed the title
dawei-nava
reviewed
Feb 12, 2024
eileen-nava
reviewed
Feb 12, 2024
Contributor
There was a problem hiding this comment.
I was confused about referring to a DocumentCaptureSessionResult object as a response, thanks for changing that.
Contributor
There was a problem hiding this comment.
This will remove the misleading info. 👍
amirbey
changed the title
dawei-nava
reviewed
Feb 14, 2024
Contributor
There was a problem hiding this comment.
double checked that the store_result is fetched by the IdvSessionConcern as the old code. 👍
… DocAuth::Response
amirbey
force-pushed
the
amirbey/LG-12370-extract-pii-from-doc-cleanup
branch
from
247370d to
e0f8ee6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-12428
Background
DocumentCaptureConcern#extract_pii_from_doc is a bit misleading. it declares response in it's signature as if it receives a DocAuth::Response when in fact the argument passed is a DocumentCaptureSessionResult which does not need to be passed as an argument.
🛠 Summary of changes