Fix static usage of error messages that results in them being untranslated#9997
Merged
mitchellhenke merged 1 commit intomainfrom Feb 15, 2024
Merged
Conversation
zachmargolis
approved these changes
Jan 29, 2024
mitchellhenke
force-pushed
the
mitchellhenke/internationalization
branch
5 times, most recently
from
6388dcf to
a9f7c40
Compare
mitchellhenke
changed the title
mitchellhenke
force-pushed
the
mitchellhenke/internationalization
branch
from
a9f7c40 to
866bc2b
Compare
…ranslated changelog: Internal, Bug Fixes, Fix static usage of error messages that results in them not being untranslated
mitchellhenke
force-pushed
the
mitchellhenke/internationalization
branch
from
866bc2b to
82dd6b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
I noticed this while doing some testing, but it seems like we only return English error messages for these. I haven't found a good way to detect it comprehensively yet though.