Revert icon reimplementation as inline style#10113
Merged
Conversation
mdiarra3
approved these changes
Feb 20, 2024
aduth
added a commit
that referenced
this pull request
Feb 28, 2024
…unrestricted inline styles (#10114) * Revert "Revert icon reimplementation as inline style (#10113)" This reverts commit ca3c16c. * Remove style-src nonce for unrestricted inline styles changelog: Bug Fixes, Content-Security Policy, Fix conflict with style-src nonce for unsafe inline styles * Add regression specs * Avoid mutating default configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Reverts #10065 and #10098
There appears to be some conflicts introduced with those pull requests related to content security policy, specifically in that revising application nonce directives restricts previously-unrestricted inline stylesheets for Acuant (and probably Threatmetrix).
Related Slack discussion: https://gsa-tts.slack.com/archives/C056RD1NEHW/p1708096788793429
I have a tentative fix for the conflict, but the revert allows for more time to test.
📜 Testing Plan
Repeat Testing Plan from #10065 and #10098