[ZIP 230, ZIP 246] Making the issuance bundle in-order-parsable#1088
Merged
Conversation
This was referenced Sep 12, 2025
daira
reviewed
Sep 14, 2025
| If $\mathtt{nIssueActions} = 0$ then ``issuerLength`` MUST be set to $0$ (``issuer`` and ``vIssueActions`` will be empty in this case). | ||
|
|
||
| * For coinbase transactions, the ``enableSpendsOrchard`` and ``enableZSAs`` bits MUST be set to $0$. | ||
|
|
Collaborator
There was a problem hiding this comment.
Comment on lines 231-232 below:
The encodings of ``tx_in``, and ``tx_out`` are as in a version 4 transaction (i.e.
unchanged from Canopy).This is copied from https://zips.z.cash/zip-0225#transaction-format , where it made sense to reference v4 and Canopy because that was the immediately preceding tx version and epoch respectively. For v6, it would either make sense to reference v5 and NU6.1, or make a stronger and more general statement:
The encodings of ``tx_in``, and ``tx_out`` are as in previous transaction versions
(i.e. unchanged since Zcash launch). [#protocol-txnencoding]_ [#zip-0225-transaction-format]_Reference #protocol-txnencoding already exists; #zip-0225-transaction-format should be:
.. [#zip-0225-transaction-format] `ZIP 225: Version 5 Transaction Format. Specification: Transaction Format <zip-0225#transaction-format>`_
daira
approved these changes
Sep 14, 2025
Collaborator
daira
left a comment
daira
left a comment
There was a problem hiding this comment.
ACK. This accurately reflects the changes agreed at the 2025-09-09 ZIP sync.
ConstanceBeguier
added a commit
to QED-it/zcash-test-vectors
that referenced
this pull request
Sep 23, 2025
…nges to ZIPs (#36) There was a rearranging of the transaction format and the digests that took place in zcash/zips#1086 and zcash/zips#1088. This PR makes the changes to the test vectors to match them back to the spec. --------- Co-authored-by: Constance Beguier <constance@qed-it.com>
ConstanceBeguier
added a commit
to QED-it/librustzcash
that referenced
this pull request
Sep 23, 2025
This PR performs the change from zcash/zips#987 to remove the asset base from the issue note description. It also makes the follow-on reorderings suggested in zcash/zips#1086 and zcash/zips#1088. The test vectors are updated in QED-it/zcash-test-vectors#36 and copied in from there. --------- Co-authored-by: Constance Beguier <constance@qed-it.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a requirement for
issuerLengthto be 0 in the case wherenIssueActions = 0, to account for the unintuitive parsing in that scenario due to the rearrangement of the issuance bundle from #1086.The diagram of the hash tree in ZIP 246 was also not updated then, so this PR brings the diagram in line with the rest of the ZIP.