[ZIP 227, ZIP, 230, ZIP 246] Fixes needed when Asset Base is not encoded in IssueNote#1086
Merged
str4d merged 8 commits intoSep 9, 2025
Merged
Conversation
daira
reviewed
Sep 9, 2025
str4d
reviewed
Sep 9, 2025
str4d
reviewed
Sep 9, 2025
str4d
reviewed
Sep 9, 2025
|
|
||
| - Every Issue Note in ``IssueAction`` MUST be a valid encoding of the $\mathsf{Note^{Issue}}$ type, and MUST encode the same $\mathsf{AssetBase}$. | ||
| - This $\mathsf{AssetBase}$ MUST satisfy the derivation from the issuer identifier and asset description described in the `Specification: Asset Identifier, Asset Digest, and Asset Base`_ section. | ||
| - An Issue Note of the $\mathsf{Note^{Issue}}$ type MUST be created for each ``IssueNote`` in the ``vNotes`` field of the ``IssueAction``, where the $\mathsf{AssetBase}$ MUST be computed from the ``assetDescHash`` field of the ``IssueAction`` and the ``issuer`` field of the issuance bundle, as described in the `Specification: Asset Identifier, Asset Digest, and Asset Base`_ section. |
Collaborator
There was a problem hiding this comment.
This need rewording:
- The MUST consensus rule re: encoding needs to still be present, but about ensuring the validity of the field encodings in
IssueNote(maybe renamed toIssueNoteDescription). - Then have a line like "Let the issue note
$\mathsf{Note^{Issue}}$ be constructed from the fields ofIssueNoteand the derived$\mathsf{AssetBase}$ from the parentIssueAction.
Co-authored-by: Jack Grigg <thestr4d@gmail.com>
str4d
approved these changes
Sep 9, 2025
Collaborator
str4d
left a comment
str4d
left a comment
There was a problem hiding this comment.
ACK 9b7cdb7 with @daira, @nuttycom, @SamHSmith, @aphelionz.
This was referenced Sep 12, 2025
ConstanceBeguier
added a commit
to QED-it/zcash-test-vectors
that referenced
this pull request
Sep 23, 2025
…nges to ZIPs (#36) There was a rearranging of the transaction format and the digests that took place in zcash/zips#1086 and zcash/zips#1088. This PR makes the changes to the test vectors to match them back to the spec. --------- Co-authored-by: Constance Beguier <constance@qed-it.com>
ConstanceBeguier
added a commit
to QED-it/librustzcash
that referenced
this pull request
Sep 23, 2025
This PR performs the change from zcash/zips#987 to remove the asset base from the issue note description. It also makes the follow-on reorderings suggested in zcash/zips#1086 and zcash/zips#1088. The test vectors are updated in QED-it/zcash-test-vectors#36 and copied in from there. --------- Co-authored-by: Constance Beguier <constance@qed-it.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the Asset Base is not included in the issue note description encoding (
IssueNote), there are a few fixes required to be made:IssueNotereduces to 115 from 147.This is a suggestion that arose from the discussion in #1081 (comment).