Removing the Asset Base from the issue note description#141
Merged
ConstanceBeguier merged 25 commits intoSep 23, 2025
Conversation
ConstanceBeguier
changed the base branch from
orchard_sighash_version
to
zsa1
ConstanceBeguier
force-pushed
the
remove_assetbase_from_issue_note_description
branch
from
f7287f5 to
c806334
Compare
PaulLaux
approved these changes
Sep 23, 2025
Collaborator
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
Approved with minor changes and pending the test vector compliance.
|
|
||
| if actions.is_empty() { | ||
| Ok(None) | ||
| let issuer_bytes = Vector::read(&mut reader, |r| r.read_u8())?; |
Collaborator
There was a problem hiding this comment.
incorrect function name. Should be issuance::read_bundle(..); (remove v6)
Also, please fix doc.
Collaborator
There was a problem hiding this comment.
same for write_v6_bundle(..) -> write_bundle(..) in this file. and the doc
Comment on lines
+159
to
+160
| CompactSize::write(&mut writer, 0)?; // empty issuer | ||
| CompactSize::write(&mut writer, 0)?; // empty vIssueActions |
Collaborator
There was a problem hiding this comment.
Move comments above the relevent line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR performs the change from zcash/zips#987 to remove the asset base from the issue note description. It also makes the follow-on reorderings suggested in zcash/zips#1086 and zcash/zips#1088.
The test vectors are updated in QED-it/zcash-test-vectors#36 and copied in from there.