Updates to digests and transaction format corresponding to recent changes to ZIPs#36
Conversation
Add compact size of the encoded signature in the digest
Update orchard_actions_compact_digest and orchard_actions_noncompact_digest personalizations
There was a problem hiding this comment.
for orchard_zsa_digest(tx): I think we need 64-bit signed little-endian
digest.update(struct.pack('<q', tx.valueBalanceOrchard)) (small <q)
Also for orchard_zsa_action_groups_auth_digest(tx): I think we need the size.
digest.update(write_compact_size(len(ag.proofsOrchard)))
digest.update(bytes(ag.proofsOrchard))Please verify.
|
About orchard_zsa_action_groups_auth_digest, I think proof compact size is not included into the digest according to ZIP 246 and ZIP 230. |
|
About |
I asked the ECC team for some clarifications about the evaluation of orchard_auth_digest.
|
This PR performs the change from zcash/zips#987 to remove the asset base from the issue note description. It also makes the follow-on reorderings suggested in zcash/zips#1086 and zcash/zips#1088. The test vectors are updated in QED-it/zcash-test-vectors#36 and copied in from there. --------- Co-authored-by: Constance Beguier <constance@qed-it.com>
There was a rearranging of the transaction format and the digests that took place in zcash/zips#1086 and zcash/zips#1088.
This PR makes the changes to the test vectors to match them back to the spec.