Skip to content

Switch to little endian encoding for everything#12

Merged
ebfull merged 7 commits into
zcash:masterfrom
ebfull:little-endian
May 18, 2018
Merged

Switch to little endian encoding for everything#12
ebfull merged 7 commits into
zcash:masterfrom
ebfull:little-endian

Conversation

@ebfull
Copy link
Copy Markdown
Collaborator

@ebfull ebfull commented May 17, 2018

@daira
Copy link
Copy Markdown
Contributor

daira commented May 17, 2018

I'm not sure whether https://github.com/zcash/librustzcash/pull/12/files#diff-745d270700285c73dedf7767652465d7R155 and https://github.com/zcash/librustzcash/pull/12/files#diff-745d270700285c73dedf7767652465d7R159 are correct. They might be, but I recommend dropping the .rev() and implementing a LittleEndianBitIterator.

daira
daira approved these changes May 17, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@daira
Copy link
Copy Markdown
Contributor

daira commented May 17, 2018

My ACK assumes that we will add test vectors generated by @str4d's independent implementation.

@ebfull ebfull mentioned this pull request May 17, 2018
Merged
@ebfull
Copy link
Copy Markdown
Collaborator Author

ebfull commented May 18, 2018

We will be adding those test vectors, but this PR will not block on them.

@str4d
Copy link
Copy Markdown
Contributor

str4d commented May 18, 2018

I have test vectors for key components, but g_d is failing. I'll figure it out tomorrow.

@ebfull
Copy link
Copy Markdown
Collaborator Author

ebfull commented May 18, 2018

We now have test coverage of Pedersen commitments, hashes, (merkle tree empty roots consistent with zcashd), note commitments, addresses/ivk, group hash, and most (all?) of jubjub.

@str4d
Copy link
Copy Markdown
Contributor

str4d commented May 18, 2018

g_d was failing in my local test vectors because the first Pedersen base was invalid, due to not rejecting points where v was not in the field. Test vectors in this PR include the fix.

str4d
str4d approved these changes May 18, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK+cov. I generated the test vectors and wrote the tests that use them, so my ACK does not cover those.

@ebfull ebfull merged commit 36d7acf into zcash:master May 18, 2018
@str4d str4d mentioned this pull request May 22, 2018
Merged
@str4d str4d mentioned this pull request Jun 5, 2018
Closed
str4d referenced this pull request in str4d/librustzcash Aug 28, 2018
@bmerge
Auto merge of #12 - ebfull:version-bump, r=ebfull
be19611 
Version bump
str4d referenced this pull request in str4d/librustzcash Aug 28, 2018
@ebfull
Rename unitary_inverse to conjugate. Closes #12.
806d34b
ebfull added a commit to ebfull/librustzcash that referenced this pull request Feb 23, 2019
@ebfull
Merge pull request zcash#12 from Eirik0/scalar-field-fr
a6601be 
Scalar field Fr
S1nus added a commit to S1nus/librustzcash that referenced this pull request Mar 7, 2026
@turbocrime @S1nus
Flexible bundle types (zcash#12)
e2f4d16 
* derive eq

* on other types

* downgrade proptest to match librustzcash

* use option for stamp in bundle

* restore type states

* review

---------

Co-authored-by: c-node <chuckhead7@gmail.com>
Co-authored-by: turbocrime <turbocrime@users.noreply.github.com>
Signed-off-by: c-node <chuckhead7@gmail.com>
greg0x referenced this pull request in valargroup/librustzcash Mar 12, 2026
@czarcas7ic
Merge pull request #12 from z-cale/roman/orchard-subtree-2
1d7de78 
Roman/orchard subtree 2
michaeltout pushed a commit to VerusCoin/librustzcash that referenced this pull request Mar 17, 2026
@who-biz
Merge pull request zcash#12 from iamahmedshahh/ka_agree-security-fixes
5cb1551 
Finalize first iteration of security improvements
nuttycom added a commit that referenced this pull request Mar 25, 2026
@nuttycom
Squashed 'zcash_client_backend/lightwallet-protocol/' changes from 23…
0696f94 
…f0768ea4..dd0ea2c3c5

dd0ea2c3c5 Merge pull request #23 from zcash/2026-03-doc-fixes
93b26b7db1 v0.4.1 release - minor doc fixups
d528fa82e3 Merge pull request #22 from zcash/2025-12-doc-git-subtree
b421ef0b34 Merge pull request #22 from zcash/2025-12-doc-git-subtree
4a26e54c36 Fix git subtree command syntax in README
34bb38b606 Merge pull request #20 from zcash/doc/get_block
a507182f92 Document GetBlock transparent data behavior and clarify nullifier RPCs
fc5cc9a4b1 Merge pull request #19 from zcash/deprecate_get_nullifiers
f0ebc72cad Mark `GetBlockNullifiers` and `GetBlockRangeNullifiers` as deprecated.
9a5f7a0eec Merge pull request #16 from zcash/2026-01-remove-fullHeader
f1095897d9 revert the previous PR that added BlockID.fullHeader
99d9bf9fff Merge pull request #15 from zcash/2025-12-compactblock-doc
bbdd689d73 either CompactBlock.{hash, prevHash}, or CompactBlock.header
aa42926ed3 Merge pull request #13 from pacu/add-README
da4d3d57d8 Add rationale suggested by @LarryRuane
4edd22465b fix type
e36df314b8 clean up whitespace and line width
215cb5a3f3 Add PR suggestions. Organize Clients section
3e78d5d872 Apply suggestions from code review
96b86544db Apply suggestion from @LarryRuane
6259b97df0 Apply suggestion from @nuttycom
f2fcef3e42 Apply suggestion from @nuttycom
8cc1e66b11 Apply suggestion from @LarryRuane
99132222dd Apply suggestion from @nuttycom
207cc5e6f9 create a README file with context and instructions
7392b9706f Merge pull request #12 from zcash/release/v0.4.0

git-subtree-dir: zcash_client_backend/lightwallet-protocol
git-subtree-split: dd0ea2c3c5827a433e62c2f936b89efa2dec5a9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daira daira daira approved these changes

@str4d str4d str4d approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ebfull @daira @str4d