Skip to content

Add read_le and write_le to PrimeFieldRepr#82

Merged
bmerge merged 5 commits into
zkcrypto:masterfrom
str4d:read-write-le
May 17, 2018
Merged

Add read_le and write_le to PrimeFieldRepr#82
bmerge merged 5 commits into
zkcrypto:masterfrom
str4d:read-write-le

Conversation

@str4d
Copy link
Copy Markdown
Member

@str4d str4d commented May 17, 2018

No description provided.

@ebfull ebfull mentioned this pull request May 17, 2018
Merged
daira
daira approved these changes May 17, 2018
View reviewed changes
Copy link
Copy Markdown
Collaborator

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. However I think there should also be a test that write_{be,le} produce specific test vectors, rather than only tests of consistency. Currently, the test would not detect if these (and read_{be,le}) were the wrong way round, for example.

@ebfull
Copy link
Copy Markdown
Collaborator

ebfull commented May 17, 2018

read_be and write_be have test vectors so that's good enough for now.

@ebfull
Copy link
Copy Markdown
Collaborator

ebfull commented May 17, 2018

@bmerge r+

@bmerge
Copy link
Copy Markdown
Collaborator

bmerge commented May 17, 2018

📌 Commit 2a28b61 has been approved by ebfull

@bmerge
Copy link
Copy Markdown
Collaborator

bmerge commented May 17, 2018

⌛ Testing commit 2a28b61 with merge 87b07f4...

bmerge added a commit that referenced this pull request May 17, 2018
@bmerge
Auto merge of #82 - str4d:read-write-le, r=ebfull
87b07f4 
Add read_le and write_le to PrimeFieldRepr
@bmerge
Copy link
Copy Markdown
Collaborator

bmerge commented May 17, 2018

💔 Test failed - pairing-linux64-auto

@ebfull
Copy link
Copy Markdown
Collaborator

ebfull commented May 17, 2018

@bmerge r+

@bmerge
Copy link
Copy Markdown
Collaborator

bmerge commented May 17, 2018

📌 Commit 97bdd16 has been approved by ebfull

@bmerge
Copy link
Copy Markdown
Collaborator

bmerge commented May 17, 2018

⌛ Testing commit 97bdd16 with merge 4c39acd...

bmerge added a commit that referenced this pull request May 17, 2018
@bmerge
Auto merge of #82 - str4d:read-write-le, r=ebfull
4c39acd 
Add read_le and write_le to PrimeFieldRepr
@bmerge
Copy link
Copy Markdown
Collaborator

bmerge commented May 17, 2018

💔 Test failed - pairing-linux64-auto

@ebfull
Copy link
Copy Markdown
Collaborator

ebfull commented May 17, 2018

@bmerge r+

@bmerge
Copy link
Copy Markdown
Collaborator

bmerge commented May 17, 2018

📌 Commit e4143a4 has been approved by ebfull

@bmerge
Copy link
Copy Markdown
Collaborator

bmerge commented May 17, 2018

⌛ Testing commit e4143a4 with merge 827db28...

bmerge added a commit that referenced this pull request May 17, 2018
@bmerge
Auto merge of #82 - str4d:read-write-le, r=ebfull
827db28 
Add read_le and write_le to PrimeFieldRepr
@bmerge
Copy link
Copy Markdown
Collaborator

bmerge commented May 17, 2018

💔 Test failed - pairing-linux64-auto

@ebfull
Copy link
Copy Markdown
Collaborator

ebfull commented May 17, 2018

@bmerge r+

@bmerge
Copy link
Copy Markdown
Collaborator

bmerge commented May 17, 2018

📌 Commit da5f1d3 has been approved by ebfull

@bmerge
Copy link
Copy Markdown
Collaborator

bmerge commented May 17, 2018

⌛ Testing commit da5f1d3 with merge 09b6e6f...

bmerge added a commit that referenced this pull request May 17, 2018
@bmerge
Auto merge of #82 - str4d:read-write-le, r=ebfull
09b6e6f 
Add read_le and write_le to PrimeFieldRepr
@bmerge
Copy link
Copy Markdown
Collaborator

bmerge commented May 17, 2018

☀️ Test successful - pairing-linux32-auto, pairing-linux64-auto, pairing-windows32msvc-auto, pairing-windows64msvc-auto
Approved by: ebfull
Pushing 09b6e6f to master...

@bmerge bmerge merged commit da5f1d3 into zkcrypto:master May 17, 2018
@str4d str4d deleted the read-write-le branch May 17, 2018 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daira daira daira approved these changes

@ebfull ebfull ebfull approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@str4d @ebfull @bmerge @daira