Add interface and computation of Sapling note nullifier#19
Merged
Conversation
Also add function priv_get_note to refactor common code from librustzcash_sapling_compute_cm.
daira
approved these changes
Jun 7, 2018
Contributor
daira
left a comment
daira
left a comment
There was a problem hiding this comment.
utACK. We should test this against vectors from the Python implementation.
Contributor
There was a problem hiding this comment.
s/nullifierand/nullifier and/
Contributor
Author
There was a problem hiding this comment.
Fixed typo and pushed (and this test file notes.rs is already testing against vectors from Python)
Rename test: commitments -> notes.
bitcartel
force-pushed
the
add_note_nullifier_computation
branch
from
e5d3bbb to
11552c1
Compare
str4d
approved these changes
Jun 8, 2018
| result: *mut [c_uchar; 32], | ||
| ) -> bool { | ||
| let note = match priv_get_note(diversifier, pk_d, value, r) { | ||
| Ok(p) => p, |
Contributor
Author
|
@zkbot r+ |
Contributor
|
@bitcartel Homu is only connected to the zcash/zcash repo (for now). |
str4d
pushed a commit
to str4d/librustzcash
that referenced
this pull request
Aug 28, 2018
Version bump.
ebfull
added a commit
to ebfull/librustzcash
that referenced
this pull request
Jun 3, 2019
Constant time everything
Duddino
pushed a commit
to Duddino/librustzcash
that referenced
this pull request
May 24, 2023
Add implementation of cyclotomic squaring for final exponentiation step
greg0x
referenced
this pull request
in valargroup/librustzcash
Mar 12, 2026
Add SQLite storage to librustvoting and wire through to iOS prototype
nuttycom
added a commit
that referenced
this pull request
Mar 25, 2026
…f0768ea4..dd0ea2c3c5 dd0ea2c3c5 Merge pull request #23 from zcash/2026-03-doc-fixes 93b26b7db1 v0.4.1 release - minor doc fixups d528fa82e3 Merge pull request #22 from zcash/2025-12-doc-git-subtree b421ef0b34 Merge pull request #22 from zcash/2025-12-doc-git-subtree 4a26e54c36 Fix git subtree command syntax in README 34bb38b606 Merge pull request #20 from zcash/doc/get_block a507182f92 Document GetBlock transparent data behavior and clarify nullifier RPCs fc5cc9a4b1 Merge pull request #19 from zcash/deprecate_get_nullifiers f0ebc72cad Mark `GetBlockNullifiers` and `GetBlockRangeNullifiers` as deprecated. 9a5f7a0eec Merge pull request #16 from zcash/2026-01-remove-fullHeader f1095897d9 revert the previous PR that added BlockID.fullHeader 99d9bf9fff Merge pull request #15 from zcash/2025-12-compactblock-doc bbdd689d73 either CompactBlock.{hash, prevHash}, or CompactBlock.header aa42926ed3 Merge pull request #13 from pacu/add-README da4d3d57d8 Add rationale suggested by @LarryRuane 4edd22465b fix type e36df314b8 clean up whitespace and line width 215cb5a3f3 Add PR suggestions. Organize Clients section 3e78d5d872 Apply suggestions from code review 96b86544db Apply suggestion from @LarryRuane 6259b97df0 Apply suggestion from @nuttycom f2fcef3e42 Apply suggestion from @nuttycom 8cc1e66b11 Apply suggestion from @LarryRuane 99132222dd Apply suggestion from @nuttycom 207cc5e6f9 create a README file with context and instructions 7392b9706f Merge pull request #12 from zcash/release/v0.4.0 git-subtree-dir: zcash_client_backend/lightwallet-protocol git-subtree-split: dd0ea2c3c5827a433e62c2f936b89efa2dec5a9a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new functions: librustzcash_sapling_compute_nf(), priv_get_note()