Circuit change for endianness#3275
Merged
Merged
Conversation
str4d
added
A-consensus
daira
approved these changes
May 18, 2018
Contributor
daira
left a comment
daira
left a comment
There was a problem hiding this comment.
utACK. I have not checked any of the hashes or test vectors.
Contributor
|
@zkbot r+ p=10 |
Contributor
|
📌 Commit 3577de8 has been approved by |
Contributor
|
@zkbot r- |
Contributor
|
@zkbot r+ p=11 |
Contributor
|
📌 Commit 3577de8 has been approved by |
Contributor
|
Hmm, priority escape of closed tree seems to not be working. @zkbot treeclosed- |
zkbot
added a commit
that referenced
this pull request
May 18, 2018
Circuit change for endianness This PR changes the circuit, encodings and parameters to match the encodings specified in the protocol spec. You'll want to `rm ~/.zcash-params/*.params` and run `./zcutil/fetch-params.sh --testnet` to switch to the new parameters for testnet.
Contributor
Contributor
This was referenced May 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the circuit, encodings and parameters to match the encodings specified in the protocol spec. You'll want to
rm ~/.zcash-params/*.paramsand run./zcutil/fetch-params.sh --testnetto switch to the new parameters for testnet.