Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #16

Closed
14 of 20 tasks
manparvesh opened this issue Aug 16, 2017 · 5 comments
Closed
14 of 20 tasks

Add tests #16

manparvesh opened this issue Aug 16, 2017 · 5 comments

Comments

@manparvesh
Copy link
Member

manparvesh commented Aug 16, 2017

Description:

Add automated tests to the project. Currently, the Travis build simply runs pytest, but since there are no tests, it passes.

This task will take a considerable effort.

Checklist:

  • chat
  • dev
    • speedtest
    • url
  • diary
    • notes
    • tasks
      • analysis
  • learn
    • vocabulary
    • flashcards
    • define
  • life
    • reading list
    • ideas
  • love
  • money
  • setup
  • feedback
  • util
@manparvesh
Copy link
Member Author

For now, #36 fixes the failing travis build. I replaces pytest with python setup.py test, and it checks if the setup builds properly.
We can use pytest in the future when the tests are written properly

@skrambol
Copy link

skrambol commented Oct 7, 2017

I'm interested in adding some tests. We can use the official testing provided by Click. Should we place the tests inside the modules or a separate directory?

@manparvesh
Copy link
Member Author

@systemplado that's cool! 😄 We should use that. We should place the tests in a different directory, since it's not a module.

manparvesh added a commit that referenced this issue Nov 26, 2017
@manparvesh
Copy link
Member Author

As suggested by @systemplado, I have started writing tests for yoda using click.testing. If someone is interested to contribute, they can take a look at the sample test file that I have written: test_speedtest.py

@wasv wasv mentioned this issue Dec 6, 2017
manparvesh added a commit that referenced this issue Dec 12, 2017
Signed-off-by: Man Parvesh Singh Randhawa <[email protected]>
manparvesh added a commit that referenced this issue Jan 28, 2018
Signed-off-by: Man Parvesh Singh Randhawa <[email protected]>
manparvesh added a commit that referenced this issue Jan 28, 2018
manparvesh added a commit that referenced this issue Jan 28, 2018
Signed-off-by: Man Parvesh Singh Randhawa <[email protected]>
manparvesh added a commit that referenced this issue Jan 28, 2018
refs #16 increase coverage for diary module
manparvesh added a commit that referenced this issue Jan 28, 2018
Signed-off-by: Man Parvesh Singh Randhawa <[email protected]>
manparvesh added a commit that referenced this issue Jan 28, 2018
Signed-off-by: Man Parvesh Singh Randhawa <[email protected]>
manparvesh added a commit that referenced this issue Jan 28, 2018
refs #16 clean up unused modules, increase coverage
manparvesh added a commit that referenced this issue Jan 28, 2018
Signed-off-by: Man Parvesh Singh Randhawa <[email protected]>
manparvesh added a commit that referenced this issue Jan 28, 2018
Signed-off-by: Man Parvesh Singh Randhawa <[email protected]>
manparvesh added a commit that referenced this issue Jan 28, 2018
Signed-off-by: Man Parvesh Singh Randhawa <[email protected]>
manparvesh added a commit that referenced this issue Jan 28, 2018
@manparvesh manparvesh mentioned this issue Jan 28, 2018
6 tasks
@manparvesh
Copy link
Member Author

I think it is okay to believe that the test coverage is fine for the project. However, I think it still needs improvement, so this will be continued in #71 and I will close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants