Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests #71

Open
2 of 6 tasks
manparvesh opened this issue Jan 28, 2018 · 5 comments
Open
2 of 6 tasks

Improve tests #71

manparvesh opened this issue Jan 28, 2018 · 5 comments

Comments

@manparvesh
Copy link
Member

manparvesh commented Jan 28, 2018

Description:

The existing tests are okay, but not very thorough. Some of the parts of the modules still lack tests.

Checklist:

  • learn
    • flashcards
  • life
    • reading list
    • ideas
  • setup

Related to: #16

@ybfe1853
Copy link

Hello, I am writing some test cases for the flashcard functionality, but i have a question. Namely with the naming of the sets:

If I try to give the set a name with length of characters larger than 1, i get the error 'the length of the name should not be more than 1', is this the intended functionality? sets cannot have names longer than 1 character? After playing around with the modify function is doesn't seem that this was intended.

@ybfe1853
Copy link

Also if it so happens that changed need to be made to the source code, should i open up separate pull requests for the test cases and the actual source code being changed?

@manparvesh
Copy link
Member Author

@ybfe1853

If I try to give the set a name with length of characters larger than 1, i get the error 'the length of the name should not be more than 1', is this the intended functionality?

I don't recall setting any limit like that 🤔

Also if it so happens that changed need to be made to the source code, should i open up separate pull requests for the test cases and the actual source code being changed?

If you mean that you want to create a new PR for the fix for restoring the length of set name, then yes. Also, please create an issue with some more details of whatever you found in that issue.

manparvesh added a commit that referenced this issue May 29, 2018
@manparvesh manparvesh modified the milestones: v0.3.0, v1.0.0 May 30, 2018
@prideloki
Copy link

prideloki commented Oct 13, 2018

Hi @manparvesh, i would like to contribute on testing ideas feature.

@manparvesh
Copy link
Member Author

@prideloki
Sure! I'd be glad to review your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants