Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refs #16 clean up unused modules, increase coverage #69

Merged
merged 2 commits into from
Jan 28, 2018
Merged

Conversation

manparvesh
Copy link
Member

Signed-off-by: Man Parvesh Singh Randhawa [email protected]

Changes proposed in this pull request:

clean up unused modules, increase coverage

Fixes: #16

Signed-off-by: Man Parvesh Singh Randhawa <[email protected]>
Signed-off-by: Man Parvesh Singh Randhawa <[email protected]>
@codecov-io
Copy link

codecov-io commented Jan 28, 2018

Codecov Report

Merging #69 into master will increase coverage by 0.81%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   58.92%   59.74%   +0.81%     
==========================================
  Files          28       23       -5     
  Lines        1322     1252      -70     
==========================================
- Hits          779      748      -31     
+ Misses        543      504      -39
Impacted Files Coverage Δ
yoda.py 89.47% <ø> (+22.05%) ⬆️
modules/__init__.py 100% <ø> (ø) ⬆️
tests/test_chat.py 100% <100%> (ø) ⬆️
tests/test_money.py 100% <100%> (ø) ⬆️
tests/test_diary.py 100% <100%> (ø) ⬆️
tests/test_love.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5ab641...0619867. Read the comment docs.

@manparvesh manparvesh merged commit cfca445 into master Jan 28, 2018
@manparvesh manparvesh added this to the v0.3.0 milestone May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants