Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds more tests. #57

Merged
merged 4 commits into from
Dec 12, 2017
Merged

Adds more tests. #57

merged 4 commits into from
Dec 12, 2017

Conversation

wasv
Copy link

@wasv wasv commented Dec 6, 2017

Short description of what this resolves:

Adding tests for each command in Yoda.

Changes proposed in this pull request:

  • Adding tests in the test/ directory.

Fixes: #16

    Checks to confirm the command returns 0, as with SpeedTest example.
@wasv
Copy link
Author

wasv commented Dec 6, 2017

This is still a work in progress. I'm submitting this pull request early to allow for comments on tests while I add them.

@codecov-io
Copy link

codecov-io commented Dec 6, 2017

Codecov Report

Merging #57 into master will increase coverage by 12.6%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   27.61%   40.21%   +12.6%     
==========================================
  Files          18       21       +3     
  Lines        1159     1206      +47     
==========================================
+ Hits          320      485     +165     
+ Misses        839      721     -118
Impacted Files Coverage Δ
tests/test_chat.py 100% <100%> (ø)
tests/test_health.py 100% <100%> (ø)
tests/test_diary.py 100% <100%> (ø)
util.py 36.53% <0%> (+3.84%) ⬆️
yoda.py 55.05% <0%> (+16.85%) ⬆️
modules/chat.py 86.95% <0%> (+30.43%) ⬆️
modules/health.py 100% <0%> (+40%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8646fb...f0546aa. Read the comment docs.

    Checks that the health command returns 0.
@manparvesh
Copy link
Member

@wastevensv
Sure, let me know whenever you are done with it.
Thanks for taking out time to contribute!

@wasv
Copy link
Author

wasv commented Dec 10, 2017

Unfortunately, I think this is as much as I will be able to do for the time being. I might try and do more another time.

@manparvesh
Copy link
Member

@wastevensv I understand. Thank you so much for contributing! 😄

@manparvesh manparvesh merged commit acb9279 into yoda-pa:master Dec 12, 2017
@wasv wasv deleted the add-tests branch December 14, 2017 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants