Remove Openssh checkpoint from hardware key test plan#56056
Merged
Conversation
zmb3
approved these changes
Jun 24, 2025
rosstimothy
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes OpenSSH checkpoint as it has never worked.
For context: during hardware key agent testing, I mistakenly thought it solved the issue with Hardware Key support and the OpenSSH client described here. What actually changed is that
tsh proxy sshis now able to prompt for PIN through the agent whereas before you would get the following error:If you run the hardware key agent, you can now get one step further, entering the PIN through the agent, but ultimately failing the key exchange:
As described in #39339 (comment), we still need a way to inject a teleport client aware of hardware keys into the key exchange. SSH Vnet has been chosen for that job as an alternative.