Add SSO MFA support for desktop access#56019
Merged
Conversation
probakowski
approved these changes
Jun 24, 2025
Co-authored-by: Przemko Robakowski <przemko.robakowski@goteleport.com>
rosstimothy
approved these changes
Jun 24, 2025
public-teleport-github-review-bot
Bot
removed the request for review
from eriktate
zmb3
reviewed
Jun 24, 2025
| ProxyAddress: h.PublicProxyAddr(), | ||
| }, nil | ||
| }, | ||
| PromptConstructor: func(...mfa.PromptOpt) mfa.Prompt { |
Collaborator
There was a problem hiding this comment.
Do SSOMFACeremonyConstructor and PromptConstructor run on the same goroutine?
Contributor
Author
There was a problem hiding this comment.
Yes. If the concern is that the channelID is set in SSOMFACeremonyConstructor, I believe I just did that so we aren't generating unused UUID's when SSO MFA is not an option. Seems like an unnecessary and bug prone optimization in hindsight.
zmb3
approved these changes
Jun 24, 2025
Contributor
This was referenced Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSO MFA support was not fully implemented on the backend for desktop access, so the WebUI would not receive SSO MFA challenges. As a result, if the user did not have webauthn configured, it had no MFA challenges to prompt for and would fail with a per session MFA error.
Changelog: Add SSO MFA support for desktop access
Closes #55436