Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix slot regression when there are multiple expressions (#952)" #963

Merged
merged 11 commits into from
Feb 6, 2024

Conversation

MoustaphaDev
Copy link
Member

@MoustaphaDev MoustaphaDev commented Feb 5, 2024

Changes

#933 ended up causing too many severe regressions so we decided to roll it back until we can do get extensive testing done for the dynamic slot feature.

Testing

Docs

Remove the references of this feature in withastro/docs#6793

Copy link

changeset-bot bot commented Feb 5, 2024

🦋 Changeset detected

Latest commit: 9d40796

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@martrapp martrapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really judge the file diff, but I went through the commits. The reverts as well as adding Nate's tests back in looks good to me.

@Princesseuh Princesseuh merged commit c17734d into main Feb 6, 2024
5 checks passed
@Princesseuh Princesseuh deleted the mk/rollback-dynamic-slots branch February 6, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants