Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix slot regression when there are multiple expressions (#952)" #963

Merged
merged 11 commits into from
Feb 6, 2024
Merged

Revert "Fix slot regression when there are multiple expressions (#952)" #963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e1a3ea9
test(#955): add failing test
natemoo-re Feb 3, 2024
617e2e8
test(#955): add another failing test
natemoo-re Feb 3, 2024
8c2bb9a
test: whoops it actually passes
natemoo-re Feb 3, 2024
0b19a4c
Revert "Fix slot regression when there are multiple expressions (#952)"
MoustaphaDev Feb 5, 2024
279140f
Revert "Fix various issues with slots (#933)"
MoustaphaDev Feb 5, 2024
0372b6e
chore: changeset
MoustaphaDev Feb 5, 2024
d6ac9c4
chore: remove slot parens in test
MoustaphaDev Feb 5, 2024
d273e63
Merge branch 'fix/955' of https://github.com/withastro/compiler into …
MoustaphaDev Feb 6, 2024
3bab6de
test: update test
MoustaphaDev Feb 6, 2024
15d68f5
chore: remove slot parens in test
MoustaphaDev Feb 6, 2024
9d40796
test: add test for #959
MoustaphaDev Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gold-bananas-drum.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@astrojs/compiler': patch
---

Rollbacks the dynamic slot generation feature to rework it
Loading
Loading