Fix slot regression when there are multiple expressions #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 336021b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
!preview mk-slot-expr-fix |
|
|
!preview mk-slot-expr-fix |
|
MoustaphaDev
commented
Jan 30, 2024
ematipico
reviewed
Jan 30, 2024
MoustaphaDev
force-pushed
the
fix-slot-regression
branch
from
fadd66a to
336021b
Compare
natemoo-re
approved these changes
Jan 30, 2024
ematipico
approved these changes
Jan 30, 2024
MoustaphaDev
added a commit
that referenced
this pull request
Feb 5, 2024
This reverts commit 418558c.
Princesseuh
pushed a commit
that referenced
this pull request
Feb 6, 2024
…" (#963) * test(#955): add failing test * test(#955): add another failing test * test: whoops it actually passes * Revert "Fix slot regression when there are multiple expressions (#952)" This reverts commit 418558c. * Revert "Fix various issues with slots (#933)" This reverts commit db13db9. * chore: changeset * chore: remove slot parens in test * test: update test * chore: remove slot parens in test * test: add test for #959 --------- Co-authored-by: Nate Moore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
mergeSlotsA regression in how we print slot was introduced in my PR in #933.
Normally, if there is more than one slotted element or any slotted element with dynamic
slotprop in an expression, we consider it a nested slot. However, instead of doing the count per expression, we aggregated it for all expressions.Because of that, if there were any slotted element in an expression, any subsequent slotted element of the same kind would be considered a nested slot
To fix that, we localized each of those states per expression
Testing
Docs
N/A bug fix only