Merged
Conversation
This was referenced Mar 9, 2023
fisx
commented
Mar 10, 2023
…-oauth-refresh-token-generation
fisx
dismissed
battermann’s stale review
changed the changelog a little - did i get this right?
fisx
commented
Mar 10, 2023
flokli
reviewed
Mar 14, 2023
flokli
reviewed
Mar 14, 2023
libs/libzauth/libzauth/Cargo.toml
Outdated
| [dev-dependencies] | ||
| clap = ">= 2.0" | ||
|
|
||
| [patch.crates-io.jwt-simple] |
Contributor
There was a problem hiding this comment.
[dependencies.jwt-simple]
git = "https://github.com/wireapp/rust-jwt-simple"
rev = "commit_id"
Also, can you add a comment stating why this was forked (what's missing from upstream), and did we send it along already?
flokli
reviewed
Mar 14, 2023
|
|
||
| zauth_keystore resources/zauth/pubkeys.txt; | ||
| zauth_acl conf/nginz/zauth_acl.txt; | ||
| oauth_key resources/oauth/ed25519_public.jwk; |
Contributor
There was a problem hiding this comment.
Suggested change
| oauth_key resources/oauth/ed25519_public.jwk; | |
| # needs to be kept in sync with services/brig/test/resources/oauth/ed25519.jwk | |
| oauth_key resources/oauth/ed25519_public.jwk; |
Contributor
There was a problem hiding this comment.
it has conflicts now, I'll add it manually.
Co-authored-by: Florian Klink <flokli@flokli.de>
This is too messy to manage manually. wireapp/rusty-jwt-tools#52 has been proposed, which adds a Cargo.lock to the repository, so we can drop this patch here.
… and also update the cargoSha256.
battermann
approved these changes
Mar 14, 2023
battermann
deleted the
SQSERVICES-1825-be-oauth-refresh-token-generation
branch
mdimjasevic
reviewed
Mar 16, 2023
Comment on lines
-345
to
+347
| :> ZConn | ||
| :> ZOptConn |
Contributor
There was a problem hiding this comment.
I'm sure this was justified, but can you clarify why is the connection ID now optional? Only the local user can call this endpoint, hence I believe we always have the connection ID.
CC: @fisx , @battermann
Contributor
There was a problem hiding this comment.
When this endpoint is called by an OAuth application, we do not have a connection ID.
lepsa
pushed a commit
to lepsa/wire-server
that referenced
this pull request
Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/SQSERVICES-1782
replaces #3086, #3046, #3010, #3004, #2985, #2931, #2922, #2907, #2901, #2882
Checklist
changelog.d