[SQSERVICES-1770] Register OAuth App (1/n)#2882
Conversation
zebot
added
the
ok-to-test
battermann
force-pushed
the
SQSERVICES-1770-be-oatuh-internal-endpoint-to-register-o-auth-app
branch
from
390921e to
b897080
Compare
battermann
changed the title
battermann
force-pushed
the
SQSERVICES-1770-be-oatuh-internal-endpoint-to-register-o-auth-app
branch
from
468d7f6 to
942f1fa
Compare
| envs: | ||
| - all | ||
| disable_zauth: true | ||
| - path: /oauth/clients/([^/]*)$ |
There was a problem hiding this comment.
probably should add that part to the changelog entry as well.
| import Test.QuickCheck.Instances () | ||
|
|
||
| data IdTag = A | C | I | U | P | S | T | STo | ||
| data IdTag = A | C | I | U | P | S | T | STo | OAuthClient |
There was a problem hiding this comment.
i like how the names get exponentially longer over time. :)
There was a problem hiding this comment.
is there a reason you're not just using a new type OAuthClientId. it's fine to reuse Id, just wondering.
There was a problem hiding this comment.
Id provides us with a lot of helpful utility functions, that's all.
| CREATE TABLE IF NOT EXISTS oauth_client | ||
| ( id uuid PRIMARY KEY | ||
| , name text | ||
| , redirect_uri blob |
There was a problem hiding this comment.
Maybe, I did this according to other table columns with the same Haskell types.
There was a problem hiding this comment.
then we should probably keep it as is for consistency.
| ] | ||
| r => | ||
| ServerT (BrigIRoutes.API :<|> IOAuthAPI) (Handler r) | ||
| servantSitemap = brigInternalAPI :<|> internalOauthAPI |
There was a problem hiding this comment.
why not add internalOAuthAPI to the list in brigInternalAPI? i would argue it's just one more thing next to mls, teams, user, auth, ...
same for public api.
| :<|> Team.servantAPI | ||
| :<|> systemSettingsAPI | ||
| ServerT (BrigAPI :<|> OAuthAPI) (Handler r) | ||
| servantSitemap = brigAPI :<|> oauthAPI |
There was a problem hiding this comment.
see comment for internal api above.
| versionApi = API.Version.tests mg brigOpts b | ||
| mlsApi = MLS.tests mg b brigOpts | ||
|
|
||
| let oauthAPI = API.OAuth.tests mg b brigOpts |
There was a problem hiding this comment.
add this line to the let block above?
|
Obsolete because of #2989 |
3 participants
https://wearezeta.atlassian.net/browse/SQSERVICES-1770
Todos
wire-api. However, refactoring should probably be done in a single branch that contains all the subsequent OAuth PRs. Also, maybe define new effects for secret generation?Checklist
changelog.dmake git-add-cassandra-schemato update the cassandra schema documentation