Skip to content

Comments

[SQSERVICES-1822] [OAUTH] Revoking a refresh token (8/n)#3010

Merged
battermann merged 13 commits intoSQSERVICES-1825-be-oauth-refresh-token-generationfrom
SQSERVICES-1822-be-oauth-revoking-refresh-token
Jan 24, 2023
Merged

[SQSERVICES-1822] [OAUTH] Revoking a refresh token (8/n)#3010
battermann merged 13 commits intoSQSERVICES-1825-be-oauth-refresh-token-generationfrom
SQSERVICES-1822-be-oauth-revoking-refresh-token

Conversation

@battermann
Copy link
Contributor

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

jschaul and others added 10 commits December 5, 2022 15:58
* Use v2 types in legacy get-conversation endpoints

* Use V3 get-conversation in most tests

* Test get-conversation@v2 endpoint directly

* Use galley v3 in brig's integration tests and RPC
The prior version relied on an image that has been removed from docker
hub. Thus, our own inbucket chart could not be deployed anymore.
* ingress compatibility k8s 1.22 and beyond

See https://kubernetes.io/docs/reference/using-api/deprecation-guide/

* batch api compatibility for k8s >= 1.25

* fixup lost closing parenthesis

* wording

* go templating: don't munch the newline break after a comment
* Hook federated API call docs into docs.wire.com (manually).

* Update fedcalls README.

* s/client api calls/api calls/

(Will also include fed calls from now on, and anyway an API is always
both a server and a client API, or it wouldn't work at all.)

* Dial down warning in link to swagger docs.

(it's gotten better since 2020)
Add sphinx-copybutton plugin to make copying snippets of code from do…
* log randomPrekey state of things

* Add an integration test to ensure list of prekeys does not become empty.

This test should also run for the dynamoDB case, to ensure our
implementation isn't buggy (it probably isn't, but to check for
regressions)

* add another test for last prekey validation

* Add one more test, fix warning from previous test

* logging on startup: log using info level, not warning

* fixup: expected status code is 201, not 200

* remove commented out code

* changelog

* linter? make format doesn't work; or local/CI don't agree
@battermann battermann temporarily deployed to cachix January 24, 2023 08:22 — with GitHub Actions Inactive
@battermann battermann temporarily deployed to cachix January 24, 2023 08:22 — with GitHub Actions Inactive
@battermann battermann changed the title revoke token [SQSERVICES-1822] [OAUTH] Revoking a refresh token Jan 24, 2023
@battermann battermann temporarily deployed to cachix January 24, 2023 09:18 — with GitHub Actions Inactive
@battermann battermann temporarily deployed to cachix January 24, 2023 09:18 — with GitHub Actions Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jan 24, 2023
@battermann battermann changed the title [SQSERVICES-1822] [OAUTH] Revoking a refresh token [SQSERVICES-1822] [OAUTH] Revoking a refresh token (6/n) Jan 24, 2023
@battermann battermann force-pushed the SQSERVICES-1822-be-oauth-revoking-refresh-token branch from a88612a to 9ac9428 Compare January 24, 2023 10:44
@battermann battermann temporarily deployed to cachix January 24, 2023 10:44 — with GitHub Actions Inactive
@battermann battermann temporarily deployed to cachix January 24, 2023 10:44 — with GitHub Actions Inactive
@battermann battermann merged commit 9ac9428 into SQSERVICES-1825-be-oauth-refresh-token-generation Jan 24, 2023
@battermann battermann deleted the SQSERVICES-1822-be-oauth-revoking-refresh-token branch January 24, 2023 10:44
@battermann battermann temporarily deployed to cachix January 24, 2023 10:45 — with GitHub Actions Inactive
@battermann battermann temporarily deployed to cachix January 24, 2023 10:45 — with GitHub Actions Inactive
@battermann battermann changed the title [SQSERVICES-1822] [OAUTH] Revoking a refresh token (6/n) [SQSERVICES-1822] [OAUTH] Revoking a refresh token (7/n) Jan 24, 2023
@battermann battermann changed the title [SQSERVICES-1822] [OAUTH] Revoking a refresh token (7/n) [SQSERVICES-1822] [OAUTH] Revoking a refresh token (8/n) Jan 24, 2023
@battermann battermann mentioned this pull request Jan 24, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants