Conversation
In addition to library code, we ship binaries here, so it's recommended to ship a `Cargo.lock` according to https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html.
This is too messy to manage manually. wireapp/rusty-jwt-tools#52 has been proposed, which adds a Cargo.lock to the repository, so we can drop this patch here.
|
Also see wireapp/wire-server@6dd43a3 for context. |
|
@flokli I get this but this will cause troubles on our side in this case. We barely use this as a binary (in fact we won't in the future). Adding a Cargo.lock here will disrupt this project's main consumer: core-crypto. Can't the Nix formula somehow ignore Cargo.lock 's hash ? |
|
I get it, but it's a bit more complicated. It'd be sufficient to just have a
It should probably be its own crate, in a separate repo, with a lockfile maintained there. |
Yes, let's do that instead |
|
Thanks, can you do this? |
|
Superseded by #54 |
|
please don't delete this branch! |
In addition to library code, we ship binaries here, so it's recommended to ship a
Cargo.lockaccording tohttps://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.
Causes (Optional)
Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.
Solutions
Briefly describe the solutions you have implemented for the issues explained above.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.