Skip to content

Comments

chore(Cargo): add Cargo.lock#52

Closed
flokli wants to merge 1 commit intomainfrom
cargo-lock
Closed

chore(Cargo): add Cargo.lock#52
flokli wants to merge 1 commit intomainfrom
cargo-lock

Conversation

@flokli
Copy link
Contributor

@flokli flokli commented Mar 14, 2023

In addition to library code, we ship binaries here, so it's recommended to ship a Cargo.lock according to
https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html.


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

In addition to library code, we ship binaries here, so it's recommended
to ship a `Cargo.lock` according to
https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html.
@flokli flokli requested review from battermann and beltram March 14, 2023 12:52
flokli added a commit to wireapp/wire-server that referenced this pull request Mar 14, 2023
This is too messy to manage manually.

wireapp/rusty-jwt-tools#52 has been proposed,
which adds a Cargo.lock to the repository, so we can drop this patch
here.
@flokli flokli changed the title add Cargo.lock chore(Cargo): add Cargo.lock Mar 14, 2023
@flokli
Copy link
Contributor Author

flokli commented Mar 14, 2023

Also see wireapp/wire-server@6dd43a3 for context.

@beltram
Copy link
Contributor

beltram commented Mar 14, 2023

@flokli I get this but this will cause troubles on our side in this case. We barely use this as a binary (in fact we won't in the future). Adding a Cargo.lock here will disrupt this project's main consumer: core-crypto.

Can't the Nix formula somehow ignore Cargo.lock 's hash ?

@flokli
Copy link
Contributor Author

flokli commented Mar 14, 2023

I get it, but it's a bit more complicated. It'd be sufficient to just have a Cargo.lock file for theffi crate, but as this is a cargo workspace there's only one global Cargo.lock.

ffi is not a library, as there's no more "other Cargo" which could generate one.

It should probably be its own crate, in a separate repo, with a lockfile maintained there.

@beltram
Copy link
Contributor

beltram commented Mar 14, 2023

It should probably be its own crate, in a separate repo, with a lockfile maintained there.

Yes, let's do that instead

@flokli
Copy link
Contributor Author

flokli commented Mar 14, 2023

Thanks, can you do this?

@beltram
Copy link
Contributor

beltram commented Mar 15, 2023

Superseded by #54

@beltram beltram closed this Mar 15, 2023
@battermann
Copy link
Contributor

please don't delete this branch!

@istankovic istankovic deleted the cargo-lock branch August 7, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants