Repository navigation
fix(wework): restore running tasks after window reopen - #1963
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (13)
📝 WalkthroughWalkthroughThe executor now returns a live ChangesRuntime running-state propagation
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant Client
participant ExecutorTranscript
participant useWorkbenchRuntimeTasks
participant useWorkbenchPaneSession
participant WorkbenchProvider
participant workbenchReducer
Client->>ExecutorTranscript: request runtime transcript
ExecutorTranscript-->>Client: return messages and running
Client->>useWorkbenchRuntimeTasks: load transcript
useWorkbenchRuntimeTasks->>useWorkbenchPaneSession: pass running state
useWorkbenchPaneSession->>WorkbenchProvider: markRuntimeTaskStarted(address)
WorkbenchProvider->>workbenchReducer: dispatch runtime_task_started
Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
qdaxb
marked this pull request as ready for review
July 15, 2026 02:37
This was referenced Jul 15, 2026
This was referenced Jul 22, 2026
This was referenced Jul 30, 2026
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runningflag from runtime transcript responsesRoot cause
The workbench previously had to combine task-list state with streaming transcript messages after a WebView was recreated. A stale task-list response could overwrite a live transcript state, while treating transcript history as authoritative would incorrectly revive interrupted tasks after the application and executor restarted.
The executor now derives transcript execution state from its in-memory active task set or the Codex app-server's live thread status. Historical
streamingmessages are display history only and no longer establish execution liveness.Validation
pnpm --filter wework test(157 test files, 1572 tests)cargo fmt,cargo test --all-features --lib, andcargo clippythrough pre-push checksNotes
The isolated verifier currently has no reopen command after
close-to-traydestroys its controlled WebView. Reopen state restoration is covered by the executor contract and workbench integration tests, including the negative stale-streaming case after executor restart.Summary by CodeRabbit
Bug Fixes
Documentation