Repository navigation
fix(wework): preserve attachment-only tasks in sidebar - #2073
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThe PR defines task identity by state-owning device and task ID, removes title-based shadow filtering, preserves distinct optimistic tasks, and adds an attachment-only desktop E2E flow with file-drop automation and scenario validation. ChangesTask identity and attachment-only sidebar validation
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant TaskFlow as task-flow.e2e.mjs
participant Automation as automation.ts
participant Composer
participant ModelServer as DesktopE2EServer
User->>TaskFlow: Start attachment-only sidebar mode
TaskFlow->>Automation: Execute dropFile command
Automation->>Composer: Dispatch drop event with decoded attachment
User->>TaskFlow: Send attachment-only task
TaskFlow->>ModelServer: Submit attachment_only request
ModelServer-->>TaskFlow: Return indexed SSE completion
TaskFlow->>Composer: Verify completion and sidebar task row
TaskFlow->>TaskFlow: Reopen or refresh desktop UI
TaskFlow->>Composer: Verify persisted sidebar rows
Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
qdaxb
marked this pull request as ready for review
July 20, 2026 07:08
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Attachment-only tasks use the default title
新对话. The previous title/workspace heuristic treated a second distinct task as the resolved form of the first optimistic task, so one row disappeared after authoritative refresh.Impact
Distinct same-title tasks remain visible. Exact task-ID reconciliation is unchanged, and task bodies are not cached or duplicated.
Verification
pnpm --filter wework exec vitest run src/features/workbench/workbenchReducer.test.ts(25 passed)pnpm --filter wework typecheckcargo test --manifest-path executor/Cargo.toml --test app_runtime_work_workspace_contract runtime_task_list_keeps_distinct_tasks_with_matching_titlespnpm --filter wework e2e:desktop:attachment-only-sidebarSummary by CodeRabbit
New Features
Bug Fixes