Merge in recent NOAA changes#13
Closed
camilleanne wants to merge 38 commits into
Closed
Conversation
…ange UST scale factor (NOAA-EMC#1050)
…ile instead of inp file (NOAA-EMC#1070)
…n binary and ascii format using switch ASCII. (NOAA-EMC#1089)
…efined in w3odatmd (size=15). Also, defined unit numbers for NDS(14) and NDS(15). (NOAA-EMC#1098)
… DIA in NL1 or NL2. (NOAA-EMC#1083)
…ST4 code (NOAA-EMC#1124) Co-authored-by: Fabrice Ardhuin <fabrice.ardhuin@ifremer.fr>
Co-authored-by: Denise Worthen <denise.worthen@noaa.gov>
| ! IS OBTAINED IN ITERATION WITH TAU>TAUW. | ||
|
|
||
| ! | ||
| IF (SINTAILPAR(1).GT.0.5) THEN |
There was a problem hiding this comment.
@StevePny This may impact the computation of ustar, z0 and charnock. I think worth testing before making a new build with this version.
| WCD = SQRT(CDRAG) | ||
| USTOLD = WINDSPEED*WCD | ||
| TAUOLD = MAX(USTOLD**2, TAUW_LOCAL+EPS1) | ||
| ! Newton method to solve for ustar in U=ustar*log(Z/Z0) |
There was a problem hiding this comment.
@StevePny this seems like a better approach to compute ustar. I'll need to complete the addition of ustar as output to our ESM.
| ! which is the same as sum of E(f,theta)*cos^3(theta-wind)*DTH*SIG^5/(g^2*2pi) | ||
| ! reminder: sum of E(f,theta)*DTH*SIG^5/(g^2*2pi) is 2*k^3*E(k) | ||
| ! | ||
| ! Computation of stress supported by tail: uses table if SINTAILPAR(1)=1 , correspoding to SINTABLE = 1 |
There was a problem hiding this comment.
@pieterbartsmit These are the most recent changes to the computation of ustar, if you want to take a look.
Author
|
closing because ancient also #15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge the most recent changes in https://github.com/NOAA-EMC/WW3 into our sofar-develop branch