matrix minor bugfixes

[mickaelaccensi]

Pull Request Summary

minor bugfixes for matrix grepping on keywords

Description

• correct error message when not finding ww3_prtide because this exe is only produced if switch TIDE is present
• redirect error output when listing ww3_prnc files for multi implementation
• change ABORT by stop to avoid misleading when detecting crashes based on keywords
• fixes run_cmake_test force to copy ww3_prtide #837
• fixes run_cmake_test crashes when finding prnc input files #838

Commit Message

minor bugfixes for matrix grepping on keywords

Check list

• Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
• Checked the checklist for a developer submitting to develop.
• If a version number update is required, checked the updating version number checklist.
• If a new feature was added, a regression test for testing the new feature is added.

Testing

• How were these changes tested?
• Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
• Have the matrix regression tests been run (if yes, please note HPC and compiler)?
• Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
• Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

[MatthewMasarik-NOAA]

@mickaelaccensi thank you for these bug fixes! I'll start the regtests.

[ukmo-ccbunney]

Hi @mickaelaccensi.

I wonder if we could add another small bugfix for matrix,comp to your PR?

I notice the the ufs regtests always run, even when not selected.

This is happening because the following lines in matrix.base are not contained in an if block:

WW3/regtests/bin/matrix.base

Lines 2152 to 2159 in 02cb72f

	# Global unstr case
	# Domain Decomposition Explicit
	fi
	echo "$rtst -s MPI -s PDLIB -i input_unstr -w work_unstr_a -g a -f -p $mpi -n $np $ww3 ww3_ufs1.1" >> matrix.body
	# Domain Decomposition Block Explicit
	echo "$rtst -s MPI -s PDLIB -i input_unstr -w work_unstr_b -g b -f -p $mpi -n $np $ww3 ww3_ufs1.1" >> matrix.body
	# Domain Decomposition Implicit
	echo "$rtst -s MPI -s PDLIB -i input_unstr -w work_unstr_c -g c -f -p $mpi -n $np $ww3 ww3_ufs1.1" >> matrix.body

I think they need to be wrapped in the following if statement (@JessicaMeixner-NOAA - can you confirm?):

if [ "$ufs" = 'y' ] && [ "$pdlib" = 'y' ] && [ "$dist" = 'y' ]; then

I'm happy to raise this a separate PR if you prefer!

[JessicaMeixner-NOAA]

Good catch @ukmo-ccbunney those should be behind UFS if statements. If @mickaelaccensi doesn't include this in this PR I can also make a separate PR to fix this.

[MatthewMasarik-NOAA]

This PR passes the regtests.

Also, it's confirmed that the ww3_prtide message (see code snippit) is no longer present.

cp: cannot stat ‘/.../bin/ww3_prtide’: No such file or directory

Matrix resutls
Only the known non-b4b.

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (7 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (11 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (14 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (14 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (16 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)
 
**********************************************************************
************************ identical cases *****************************
**********************************************************************

• matrixCompSummary.txt
• matrixCompFull.txt
• matrixDiff.txt

Code Review
PASS

Regtests
PASS

[MatthewMasarik-NOAA]

I will merge this PR as is since the review has been done.

Chris had a good tip though for a fix (#1049 (comment)) regarding the ww3_ufs test selection, fyi @mickaelaccensi @ukmo-ccbunney @JessicaMeixner-NOAA