Skip to content

[Model] Deprecate the score task (this will not affect users). #37537

Merged
noooop merged 7 commits intovllm-project:mainfrom
noooop:deprecate_score
Mar 20, 2026
Merged

[Model] Deprecate the score task (this will not affect users). #37537
noooop merged 7 commits intovllm-project:mainfrom
noooop:deprecate_score

Conversation

@noooop
Copy link
Collaborator

@noooop noooop commented Mar 19, 2026

Purpose

Cross-encoder (aka reranker) models are a subset of classification models that accept two prompts as input and output num_labels equal to 1.

In the engine, we will no longer differentiate between classify and score. So we can deprecate the score task.

This is part of deprecate support for multi-task.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully deprecates the 'score' task, replacing it with 'classify' where appropriate and removing related logic and comments. The changes are consistent across tests, model configuration, entrypoints, and model executor components. The refactoring of activation functions and renaming of variables like pooled_data to embeddings or logits enhances code clarity and maintainability. No critical or high-severity issues were found in the changes.

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@noooop noooop marked this pull request as ready for review March 19, 2026 09:05
@noooop noooop added ready ONLY add when PR is ready to merge/full CI is needed and removed ready ONLY add when PR is ready to merge/full CI is needed labels Mar 19, 2026
@mergify
Copy link

mergify bot commented Mar 19, 2026

Hi @noooop, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?
mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@noooop noooop added ready ONLY add when PR is ready to merge/full CI is needed and removed ready ONLY add when PR is ready to merge/full CI is needed labels Mar 19, 2026
@mergify
Copy link

mergify bot commented Mar 20, 2026

Documentation preview: https://vllm--37537.org.readthedocs.build/en/37537/

@mergify mergify bot added the documentation Improvements or additions to documentation label Mar 20, 2026
@noooop noooop requested a review from DarkLight1337 March 20, 2026 00:15
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 20, 2026 02:41
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 20, 2026
@DarkLight1337 DarkLight1337 disabled auto-merge March 20, 2026 02:41
@noooop noooop enabled auto-merge (squash) March 20, 2026 03:03
@noooop noooop merged commit ed359c4 into vllm-project:main Mar 20, 2026
74 checks passed
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Mar 21, 2026
chooper26 pushed a commit to intellistream/vllm-hust that referenced this pull request Mar 21, 2026
@noooop noooop deleted the deprecate_score branch March 21, 2026 04:57
@robertgshaw2-redhat
Copy link
Collaborator

@noooop - this broke CI
@DarkLight1337 - please ensure we run relevant tests

@noooop
Copy link
Collaborator Author

noooop commented Mar 22, 2026

image

@noooop
Copy link
Collaborator Author

noooop commented Mar 22, 2026

image

@noooop
Copy link
Collaborator Author

noooop commented Mar 22, 2026

Perhaps it was caused by #37303, and it should be fixable by #37775.

cc @robertgshaw2-redhat @AndreasKaratzas

@AndreasKaratzas
Copy link
Collaborator

AndreasKaratzas commented Mar 22, 2026

@noooop i can open it, i just want also #37774 to be merged so that amd ci is evaluated as well. Can we merge 37774 first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation frontend ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants