[ROCm][CI] close missing quote in kernels/moe block in run-amd-test.sh#37774
Merged
noooop merged 1 commit intovllm-project:mainfrom Mar 22, 2026
Merged
[ROCm][CI] close missing quote in kernels/moe block in run-amd-test.sh#37774noooop merged 1 commit intovllm-project:mainfrom
noooop merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
AndreasKaratzas
requested review from
DarkLight1337,
robertgshaw2-redhat and
tjtanaa
AndreasKaratzas
added
rocm
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a syntax error in the .buildkite/scripts/hardware_ci/run-amd-test.sh script. The change adds a missing closing quote to a string assignment, which resolves the issue. The fix is straightforward and effective.
5 tasks
noooop
approved these changes
Mar 22, 2026
yzong-rh
pushed a commit
to yzong-rh/vllm
that referenced
this pull request
Mar 23, 2026
vllm-project#37774) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses regression from: #32700
Fix a syntax error in
run-amd-test.shwhere thekernels/moeignore block insideapply_rocm_test_overrideswas missing the closing"on thecmdsstring assignment.cc @kenroche