[Deprecate] Deprecate pooling multi task support.#37956
[Deprecate] Deprecate pooling multi task support.#37956noooop merged 17 commits intovllm-project:mainfrom
Conversation
|
Documentation preview: https://vllm--37956.org.readthedocs.build/en/37956/ |
There was a problem hiding this comment.
Code Review
This pull request effectively deprecates multi-task support for pooling models, encouraging users to specify a single task. The changes are well-structured, with logic centralized in ModelConfig.get_pooling_task and LLM._verify_pooling_task. The documentation and tests have been updated accordingly to reflect this deprecation. I've found one issue in a test case that needs to be addressed.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: wang.yuqi <noooop@126.com>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request deprecates multi-task support for pooling models, introducing a default pooling task for each model and issuing a warning when a non-default task is used. The changes are well-structured, with updates to configuration, entrypoints, tests, and documentation to reflect this deprecation. The refactoring to centralize task verification logic in _verify_pooling_task is a good improvement. I've found a couple of issues with incorrect error messages that could mislead users, for which I've left specific comments.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: wang.yuqi <noooop@126.com>
|
Ready for review |
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com> Signed-off-by: wang.yuqi <noooop@126.com>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Purpose
Following #37537 #37632
Pooling multitask support is deprecated and will be removed in v0.20.
When the default pooling task is not what you want, you need to manually specify it via
PoolerConfig(task=<task>)offline or--pooler-config.task <task>online.Remove pooling multi task support. #37861
Test Plan
keep ci green
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.