Skip to content

[Deprecate] Deprecate pooling multi task support.#37956

Merged
noooop merged 17 commits intovllm-project:mainfrom
noooop:deprecate_multi_task
Mar 24, 2026
Merged

[Deprecate] Deprecate pooling multi task support.#37956
noooop merged 17 commits intovllm-project:mainfrom
noooop:deprecate_multi_task

Conversation

@noooop
Copy link
Collaborator

@noooop noooop commented Mar 24, 2026

Purpose

Following #37537 #37632

Pooling multitask support is deprecated and will be removed in v0.20.

When the default pooling task is not what you want, you need to manually specify it via PoolerConfig(task=<task>) offline or --pooler-config.task <task> online.

Remove pooling multi task support. #37861

Test Plan

keep ci green

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

noooop added 2 commits March 24, 2026 11:14
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@mergify
Copy link

mergify bot commented Mar 24, 2026

Documentation preview: https://vllm--37956.org.readthedocs.build/en/37956/

@mergify mergify bot added documentation Improvements or additions to documentation frontend labels Mar 24, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively deprecates multi-task support for pooling models, encouraging users to specify a single task. The changes are well-structured, with logic centralized in ModelConfig.get_pooling_task and LLM._verify_pooling_task. The documentation and tests have been updated accordingly to reflect this deprecation. I've found one issue in a test case that needs to be addressed.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: wang.yuqi <noooop@126.com>
@noooop
Copy link
Collaborator Author

noooop commented Mar 24, 2026

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request deprecates multi-task support for pooling models, introducing a default pooling task for each model and issuing a warning when a non-default task is used. The changes are well-structured, with updates to configuration, entrypoints, tests, and documentation to reflect this deprecation. The refactoring to centralize task verification logic in _verify_pooling_task is a good improvement. I've found a couple of issues with incorrect error messages that could mislead users, for which I've left specific comments.

noooop and others added 2 commits March 24, 2026 11:36
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: wang.yuqi <noooop@126.com>
@noooop
Copy link
Collaborator Author

noooop commented Mar 24, 2026

cc @DarkLight1337

Ready for review

noooop added 2 commits March 24, 2026 11:52
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
noooop and others added 2 commits March 24, 2026 13:49
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: wang.yuqi <noooop@126.com>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@vllm-project vllm-project deleted a comment from mergify bot Mar 24, 2026
@vllm-project vllm-project deleted a comment from mergify bot Mar 24, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@vllm-project vllm-project deleted a comment from mergify bot Mar 24, 2026
noooop added 2 commits March 24, 2026 14:18
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@vllm-project vllm-project deleted a comment from mergify bot Mar 24, 2026
@vllm-project vllm-project deleted a comment from mergify bot Mar 24, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@noooop noooop added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 24, 2026
@noooop noooop removed the ready ONLY add when PR is ready to merge/full CI is needed label Mar 24, 2026
noooop added 2 commits March 24, 2026 17:51
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@noooop noooop enabled auto-merge (squash) March 24, 2026 12:41
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 24, 2026
@noooop noooop merged commit 1b6cb92 into vllm-project:main Mar 24, 2026
57 checks passed
@noooop noooop deleted the deprecate_multi_task branch March 24, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants