[Frontend] Remove pooling multi task support. (Hold off until v0.20.0)#37861
[Frontend] Remove pooling multi task support. (Hold off until v0.20.0)#37861noooop wants to merge 10 commits intovllm-project:mainfrom
Conversation
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
|
Hi @noooop, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
| if self.pooler_config.pooling_task in supported_tasks: | ||
| return self.pooler_config.pooling_task | ||
| else: | ||
| raise RuntimeError( |
There was a problem hiding this comment.
I mean that we should still allow user-specified pooling tasks, but with a warning, until the deprecation period (2 minor versions) is complete, then we can remove it fully
There was a problem hiding this comment.
I'm not sure @WoosukKwon is willing to wait two versions, over a month.
There was a problem hiding this comment.
I think we should still honor this policy. That's kinda why he wanted to start the deprecation process ASAP.
There was a problem hiding this comment.
I will submit a PR with a warning version. If we're not in a hurry to deprecate it directly, just like this.
There was a problem hiding this comment.
Anyway, this PR provides a very solid foundation for the next steps.
|
Hi @noooop, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
|
This pull request has merge conflicts that must be resolved before it can be |
Purpose
Following #37537 #37632 #37956
Remove frontend pooling multi task support.
When the default pooling task is not what you want, you need to manually specify it via PoolerConfig(pooling_task="...") offline or --pooler-config {"pooling_task": "..."} online.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.