Skip to content

[Frontend] Remove pooling multi task support. (Hold off until v0.20.0)#37861

Draft
noooop wants to merge 10 commits intovllm-project:mainfrom
noooop:deprecate_multi_task_ux
Draft

[Frontend] Remove pooling multi task support. (Hold off until v0.20.0)#37861
noooop wants to merge 10 commits intovllm-project:mainfrom
noooop:deprecate_multi_task_ux

Conversation

@noooop
Copy link
Collaborator

@noooop noooop commented Mar 23, 2026

Purpose

Following #37537 #37632 #37956

Remove frontend pooling multi task support.

When the default pooling task is not what you want, you need to manually specify it via PoolerConfig(pooling_task="...") offline or --pooler-config {"pooling_task": "..."} online.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@mergify mergify bot added the frontend label Mar 23, 2026
@gemini-code-assist
Copy link
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

noooop added 6 commits March 23, 2026 16:27
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@noooop noooop added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 23, 2026
@noooop noooop changed the title [Frontend] Deprecate pooling multi task support. [wip][Frontend] Deprecate pooling multi task support. Mar 23, 2026
@mergify
Copy link

mergify bot commented Mar 23, 2026

Hi @noooop, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?
mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

noooop added 2 commits March 23, 2026 23:43
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
if self.pooler_config.pooling_task in supported_tasks:
return self.pooler_config.pooling_task
else:
raise RuntimeError(
Copy link
Member

@DarkLight1337 DarkLight1337 Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean that we should still allow user-specified pooling tasks, but with a warning, until the deprecation period (2 minor versions) is complete, then we can remove it fully

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure @WoosukKwon is willing to wait two versions, over a month.

Copy link
Member

@DarkLight1337 DarkLight1337 Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should still honor this policy. That's kinda why he wanted to start the deprecation process ASAP.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will submit a PR with a warning version. If we're not in a hurry to deprecate it directly, just like this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, this PR provides a very solid foundation for the next steps.

@noooop noooop changed the title [wip][Frontend] Deprecate pooling multi task support. [wip][Frontend] Deprecate pooling multi task support. (Hold off until v0.20.0) Mar 23, 2026
@mergify
Copy link

mergify bot commented Mar 23, 2026

Hi @noooop, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?
mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

@noooop noooop marked this pull request as draft March 24, 2026 00:36
@noooop noooop changed the title [wip][Frontend] Deprecate pooling multi task support. (Hold off until v0.20.0) [Frontend] Deprecate pooling multi task support. (Hold off until v0.20.0) Mar 24, 2026
@noooop noooop changed the title [Frontend] Deprecate pooling multi task support. (Hold off until v0.20.0) [Frontend] Remove pooling multi task support. (Hold off until v0.20.0) Mar 24, 2026
@mergify
Copy link

mergify bot commented Mar 24, 2026

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @noooop.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend needs-rebase ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants